Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1410305

[PATCH] befs: remove unused endian functions

From Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups linux.kernel
Subject [PATCH] befs: remove unused endian functions
Date 2016-05-31 15:30 +0200
Message-ID <rERU6-3h1-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Remove endianness conversion functions that are declared but never used.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---

Hi,

Continuing to learn the BeFS code. Noticed some cleanup.

Thanks for the review :)

Luis

 fs/befs/endian.h | 44 --------------------------------------------
 1 file changed, 44 deletions(-)

diff --git a/fs/befs/endian.h b/fs/befs/endian.h
index 2722387..3163ee6 100644
--- a/fs/befs/endian.h
+++ b/fs/befs/endian.h
@@ -20,15 +20,6 @@ fs64_to_cpu(const struct super_block *sb, fs64 n)
 		return be64_to_cpu((__force __be64)n);
 }
 
-static inline fs64
-cpu_to_fs64(const struct super_block *sb, u64 n)
-{
-	if (BEFS_SB(sb)->byte_order == BEFS_BYTESEX_LE)
-		return (__force fs64)cpu_to_le64(n);
-	else
-		return (__force fs64)cpu_to_be64(n);
-}
-
 static inline u32
 fs32_to_cpu(const struct super_block *sb, fs32 n)
 {
@@ -38,15 +29,6 @@ fs32_to_cpu(const struct super_block *sb, fs32 n)
 		return be32_to_cpu((__force __be32)n);
 }
 
-static inline fs32
-cpu_to_fs32(const struct super_block *sb, u32 n)
-{
-	if (BEFS_SB(sb)->byte_order == BEFS_BYTESEX_LE)
-		return (__force fs32)cpu_to_le32(n);
-	else
-		return (__force fs32)cpu_to_be32(n);
-}
-
 static inline u16
 fs16_to_cpu(const struct super_block *sb, fs16 n)
 {
@@ -56,15 +38,6 @@ fs16_to_cpu(const struct super_block *sb, fs16 n)
 		return be16_to_cpu((__force __be16)n);
 }
 
-static inline fs16
-cpu_to_fs16(const struct super_block *sb, u16 n)
-{
-	if (BEFS_SB(sb)->byte_order == BEFS_BYTESEX_LE)
-		return (__force fs16)cpu_to_le16(n);
-	else
-		return (__force fs16)cpu_to_be16(n);
-}
-
 /* Composite types below here */
 
 static inline befs_block_run
@@ -84,23 +57,6 @@ fsrun_to_cpu(const struct super_block *sb, befs_disk_block_run n)
 	return run;
 }
 
-static inline befs_disk_block_run
-cpu_to_fsrun(const struct super_block *sb, befs_block_run n)
-{
-	befs_disk_block_run run;
-
-	if (BEFS_SB(sb)->byte_order == BEFS_BYTESEX_LE) {
-		run.allocation_group = cpu_to_le32(n.allocation_group);
-		run.start = cpu_to_le16(n.start);
-		run.len = cpu_to_le16(n.len);
-	} else {
-		run.allocation_group = cpu_to_be32(n.allocation_group);
-		run.start = cpu_to_be16(n.start);
-		run.len = cpu_to_be16(n.len);
-	}
-	return run;
-}
-
 static inline befs_data_stream
 fsds_to_cpu(const struct super_block *sb, const befs_disk_data_stream *n)
 {
-- 
2.5.1

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] befs: remove unused endian functions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-05-31 15:30 +0200
  Re: [PATCH] befs: remove unused endian functions Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-31 23:00 +0200
    Re: [PATCH] befs: remove unused endian functions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-05-31 23:00 +0200
      Re: [PATCH] befs: remove unused endian functions Andrew Morton <akpm@linux-foundation.org> - 2016-06-01 21:30 +0200
        Re: [PATCH] befs: remove unused endian functions Andrew Morton <akpm@linux-foundation.org> - 2016-06-01 21:40 +0200
          Re: [PATCH] befs: remove unused endian functions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-01 21:50 +0200
        Re: [PATCH] befs: remove unused endian functions Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-06-01 21:40 +0200

csiph-web