Re: [PATCH 3/7] iio: adc: ad7793: claim direct mode when writing frequency

From	Lars-Peter Clausen <lars@metafoo.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/7] iio: adc: ad7793: claim direct mode when writing frequency
Date	2016-05-31 15:30 +0200
Message-ID	<rERU6-3h1-21@gated-at.bofh.it> (permalink)
References	<rCq1X-7jq-3@gated-at.bofh.it> <rCq1X-7jq-21@gated-at.bofh.it> <rCEoi-8jG-13@gated-at.bofh.it> <rEdN0-1qk-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/29/2016 08:33 PM, Jonathan Cameron wrote:
> On 25/05/16 11:36, Daniel Baluta wrote:
>> On Tue, May 24, 2016 at 10:17 PM, Alison Schofield <amsfield22@gmail.com> wrote:
>>> Driver was checking for direct mode and trying to lock it, but
>>> left a gap where mode could change before the desired operation.
>>> Use iio_device_claim_direct_mode() to guarantee device stays in
>>> direct mode.
>>>
>>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
>>
>> Acked-by: Daniel Baluta <daniel.baluta@gmail.com>
> Again, this one is not quite so trivial so I'll wait for Lars to take a look
> even though I'm happy with it.

Same as patch too. Looks good otherwise.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/7] iio: adc: ad7793: claim direct mode when writing  frequency Alison Schofield <amsfield22@gmail.com> - 2016-05-24 21:20 +0200
  Re: [PATCH 3/7] iio: adc: ad7793: claim direct mode when writing frequency Daniel Baluta <daniel.baluta@gmail.com> - 2016-05-25 12:40 +0200
    Re: [PATCH 3/7] iio: adc: ad7793: claim direct mode when writing  frequency Jonathan Cameron <jic23@kernel.org> - 2016-05-29 20:40 +0200
      Re: [PATCH 3/7] iio: adc: ad7793: claim direct mode when writing  frequency Lars-Peter Clausen <lars@metafoo.de> - 2016-05-31 15:30 +0200

csiph-web