[PATCH 2/2] powerpc/mm: check for irq disabled() only if DEBUG_VM is enabled.

From	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] powerpc/mm: check for irq disabled() only if DEBUG_VM is enabled.
Date	2016-05-31 13:10 +0200
Message-ID	<rEPIC-1X8-17@gated-at.bofh.it> (permalink)
References	<rEPIC-1X8-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

We don't need to check this always. The idea here is to capture the
wrong usage of find_linux_pte_or_hugepte and we can do that by
occasionally running with DEBUG_VM enabled.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 arch/powerpc/include/asm/pgtable.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/include/asm/pgtable.h b/arch/powerpc/include/asm/pgtable.h
index ee09e99097f0..9bd87f269d6d 100644
--- a/arch/powerpc/include/asm/pgtable.h
+++ b/arch/powerpc/include/asm/pgtable.h
@@ -71,10 +71,8 @@ pte_t *__find_linux_pte_or_hugepte(pgd_t *pgdir, unsigned long ea,
 static inline pte_t *find_linux_pte_or_hugepte(pgd_t *pgdir, unsigned long ea,
 					       bool *is_thp, unsigned *shift)
 {
-	if (!arch_irqs_disabled()) {
-		pr_info("%s called with irq enabled\n", __func__);
-		dump_stack();
-	}
+	VM_WARN(!arch_irqs_disabled(),
+		"%s called with irq enabled\n", __func__);
 	return __find_linux_pte_or_hugepte(pgdir, ea, is_thp, shift);
 }
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] powerpc/mm: check for irq disabled() only if DEBUG_VM is enabled. "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-05-31 13:10 +0200
  Re: [PATCH 2/2] powerpc/mm: check for irq disabled() only if DEBUG_VM  is enabled. Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2016-06-07 09:00 +0200
  Re: [PATCH 2/2] powerpc/mm: check for irq disabled() only if DEBUG_VM  is enabled. Balbir Singh <bsingharora@gmail.com> - 2016-06-07 10:40 +0200

csiph-web