Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1410087

Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c

From Ian Abbott <abbotti@mev.co.uk>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c
Date 2016-05-31 12:30 +0200
Message-ID <rEP5U-1qK-5@gated-at.bofh.it> (permalink)
References <rDEYV-4Tt-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a type issues like
> i.e Prefer kernel type 'u8' over 'uint8_t'
>      Prefer kernel type 'u16' over 'uint16_t'
>      Prefer kernel type 'u32' over 'uint32_t'
>      Prefer kernel type 's16' over 'int16_t'
>      Prefer kernel type 's32' over 'int32_t'
> found by the checkpatch.pl tool.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
> ---
> changes since v1: Rework
> ---
>   drivers/staging/comedi/drivers/s626.c | 212 +++++++++++++++++-----------------
>   1 file changed, 106 insertions(+), 106 deletions(-)
>

Thanks.  It would have been nice if the checkpatch.pl tool detected 
_all_ the instances of these types.  As a result of this patch, s626.c 
contains a mixture of the different integer type styles.  I guess we can 
fix that up later though.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 1/4] staging : comedi : fix type issues in s626.c Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com> - 2016-05-28 07:30 +0200
  Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-05-30 16:10 +0200
  Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c Ian Abbott <abbotti@mev.co.uk> - 2016-05-31 12:30 +0200
    Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c Joe Perches <joe@perches.com> - 2016-05-31 19:10 +0200
      Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c Ian Abbott <abbotti@mev.co.uk> - 2016-06-01 11:30 +0200

csiph-web