Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1410007

Re: [PATCH] pinctrl: imx: fix initialization of imx_pinctrl_desc

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] pinctrl: imx: fix initialization of imx_pinctrl_desc
Date 2016-05-31 11:00 +0200
Message-ID <rENGO-pS-19@gated-at.bofh.it> (permalink)
References <rA67o-eQ-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, May 18, 2016 at 11:31 AM, Peng Fan <van.freenix@gmail.com> wrote:

> To i.MX7D, there are two iomux controllers, iomuxc and iomuxc_lpsr.
> They should not share one pin controller descriptor, otherwise
> the value filled into imx_pinctrl_desc when probing the first
> iomux controller will be overridden when probing the second one.
>
> In this patch, discard the static allcoated imx_pinctrl_desc and
> switch to dynamically allcate pin controller descriptor for each
> iomux controller.
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Stefan Agner <stefan@agner.ch>
> Cc: Vladimir Zapolskiy <vz@mleia.com>

Looks reasonable to me so patch applied since noone is responding.

Yours,
Linus Walleij

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] pinctrl: imx: fix initialization of imx_pinctrl_desc Peng Fan <van.freenix@gmail.com> - 2016-05-18 11:40 +0200
  Re: [PATCH] pinctrl: imx: fix initialization of imx_pinctrl_desc Peng Fan <van.freenix@gmail.com> - 2016-05-30 15:00 +0200
  Re: [PATCH] pinctrl: imx: fix initialization of imx_pinctrl_desc Linus Walleij <linus.walleij@linaro.org> - 2016-05-31 11:00 +0200

csiph-web