Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1409933

Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace in 4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage)

From Dave Chinner <david@fromorbit.com>
Newsgroups linux.kernel
Subject Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace in 4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage)
Date 2016-05-31 09:40 +0200
Message-ID <rEMrn-83O-9@gated-at.bofh.it> (permalink)
References (5 earlier) <rEGlY-3Nt-13@gated-at.bofh.it> <rEI4p-4Qc-3@gated-at.bofh.it> <rEJ0t-5zg-1@gated-at.bofh.it> <rEL2h-75S-7@gated-at.bofh.it> <rELbY-79h-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, May 31, 2016 at 08:11:42AM +0200, Stefan Priebe - Profihost AG wrote:
> > I'm half tempted at this point to mostly ignore this mm/ behavour
> > because we are moving down the path of removing buffer heads from
> > XFS. That will require us to do different things in ->releasepage
> > and so just skipping dirty pages in the XFS code is the best thing
> > to do....
> 
> does this change anything i should test? Or is 4.6 still the way to go?

Doesn't matter now - the warning will still be there on 4.6. I think
you can simply ignore it as the XFS code appears to be handling the
dirty page that is being passed to it correctly. We'll work out what
needs to be done to get rid of the warning for this case, wether it
be a mm/ change or an XFS change.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

shrink_active_list/try_to_release_page bug? (was Re: xfs trace in  4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Dave Chinner <david@fromorbit.com> - 2016-05-31 00:40 +0200
  Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace  in 4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Minchan Kim <minchan@kernel.org> - 2016-05-31 03:10 +0200
    Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace  in 4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Dave Chinner <david@fromorbit.com> - 2016-05-31 05:00 +0200
      Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace  in 4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Minchan Kim <minchan@kernel.org> - 2016-05-31 06:00 +0200
        Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace  in 4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Dave Chinner <david@fromorbit.com> - 2016-05-31 08:10 +0200
          Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace in  4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Stefan Priebe - Profihost AG <s.priebe@profihost.ag> - 2016-05-31 08:20 +0200
            Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace  in 4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Dave Chinner <david@fromorbit.com> - 2016-05-31 09:40 +0200
              Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace in  4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Stefan Priebe - Profihost AG <s.priebe@profihost.ag> - 2016-05-31 10:10 +0200
              Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace in  4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Stefan Priebe - Profihost AG <s.priebe@profihost.ag> - 2016-06-02 14:20 +0200
                Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace in  4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Holger Hoffstätte <holger@applied-asynchrony.com> - 2016-06-02 14:50 +0200
                Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace  in 4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Dave Chinner <david@fromorbit.com> - 2016-06-03 01:10 +0200
    Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace  in 4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Jan Kara <jack@suse.cz> - 2016-05-31 12:00 +0200
      Re: shrink_active_list/try_to_release_page bug? (was Re: xfs trace  in 4.4.2 / also in 4.3.3 WARNING fs/xfs/xfs_aops.c:1232 xfs_vm_releasepage) Minchan Kim <minchan@kernel.org> - 2016-06-01 03:40 +0200

csiph-web