Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

From	Gerd Hoffmann <kraxel@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support
Date	2016-05-31 09:40 +0200
Message-ID	<rEMrn-83O-7@gated-at.bofh.it> (permalink)
References	(5 earlier) <rEr3A-1OX-27@gated-at.bofh.it> <rEub8-40L-15@gated-at.bofh.it> <rEwFX-5sh-1@gated-at.bofh.it> <rELbY-79h-5@gated-at.bofh.it> <rELvl-7hB-65@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

  Hi,

> > Right now the virtual outputs are linked to drm_crtc.  To apply any
> > changes I need to lookup the crtc to figure which virtual output should
> > be updated.

> > So, setting active_only should make sure I have a valid crtc pointer on
> > plane updates, right?  It probably also skips the disable + enable crtc
> > steps on commit?  What happens when outputs are disabled?

> Nah, I just misunderstood your patch. If it's all about finding the
> corresponding crtc, then you're all good.

Yes, it's all about finding the crtc.

> I thought there was some
> other reason (like the virtual hw getting upset about certain things).

virtio wouldn't be upset.

It's a pointless exercise though to first disable the output, just to
re-enable it the next moment with the new page-flipped framebuffer.  So
I guess I should look at the active_only thing nevertheless.

> btw can you pls drop an ack or r-b
> onto my virtio conversion? I already added your tested-by.

Grr, mail is not in my dri-devel folder.  Guess that is the <censored>
"avoid-duplicates" mailman option at work.

Feel free to just add the r-b too.  Or I'll send it for the next version
of the series.

cheers,
  Gerd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Daniel Vetter <daniel@ffwll.ch> - 2016-05-25 18:40 +0200
  Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Gerd Hoffmann <kraxel@redhat.com> - 2016-05-27 09:50 +0200
    Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Daniel Vetter <daniel@ffwll.ch> - 2016-05-27 10:00 +0200
      Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Daniel Vetter <daniel@ffwll.ch> - 2016-05-30 10:50 +0200
        Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Gerd Hoffmann <kraxel@redhat.com> - 2016-05-30 14:10 +0200
          Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Daniel Vetter <daniel@ffwll.ch> - 2016-05-30 16:50 +0200
            Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Gerd Hoffmann <kraxel@redhat.com> - 2016-05-31 08:20 +0200
              Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Daniel Vetter <daniel@ffwll.ch> - 2016-05-31 08:40 +0200
                Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Daniel Vetter <daniel@ffwll.ch> - 2016-05-31 09:40 +0200
                Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Gerd Hoffmann <kraxel@redhat.com> - 2016-05-31 09:40 +0200

csiph-web