[PATCH 08/15] thermal: sysfs: improve locking of emul_temp_store()

From	Eduardo Valentin <edubezval@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 08/15] thermal: sysfs: improve locking of emul_temp_store()
Date	2016-05-31 08:40 +0200
Message-ID	<rELvk-7hB-31@gated-at.bofh.it> (permalink)
References	<rELvj-7hB-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

emul_temp_store locks only for setting temperature,
but it must lock also for calls to tz.ops.

Cc: Zhang Rui <rui.zhang@intel.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
---
 drivers/thermal/thermal_sysfs.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c
index 234eb18..32ffadf 100644
--- a/drivers/thermal/thermal_sysfs.c
+++ b/drivers/thermal/thermal_sysfs.c
@@ -340,13 +340,12 @@ emul_temp_store(struct device *dev, struct device_attribute *attr,
 	if (kstrtoint(buf, 10, &temperature))
 		return -EINVAL;
 
-	if (!tz->ops->set_emul_temp) {
-		mutex_lock(&tz->lock);
+	mutex_lock(&tz->lock);
+	if (!tz->ops->set_emul_temp)
 		tz->emul_temperature = temperature;
-		mutex_unlock(&tz->lock);
-	} else {
+	else
 		ret = tz->ops->set_emul_temp(tz, temperature);
-	}
+	mutex_unlock(&tz->lock);
 
 	if (!ret)
 		thermal_zone_device_update(tz);
-- 
2.1.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 08/15] thermal: sysfs: improve locking of emul_temp_store() Eduardo Valentin <edubezval@gmail.com> - 2016-05-31 08:40 +0200

csiph-web