Re: [PATCH] block: correctly fallback for zeroout

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] block: correctly fallback for zeroout
Date	2016-05-29 08:50 +0200
Message-ID	<rE2HT-2Ek-1@gated-at.bofh.it> (permalink)
References	<rD7Tk-1g2-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 26, 2016 at 11:08:14AM -0700, Shaohua Li wrote:
> -int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
> -		sector_t nr_sects, gfp_t gfp_mask, unsigned long flags)
> +static int do_blkdev_issue_discard(struct block_device *bdev, sector_t sector,

We've split blkdev_issue_discard into __blkdev_issue_discard and a small
wrapper around in for 4.7, so this will need a bit of an update.

As part of that I also removed the strange EOPNOTSUPP ignore, but Mike
reverted it just because it changed something in the dm testsuite.

I still believe we should never ignore it in this helper, and only
do so in callers that believe it's the right thing.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] block: correctly fallback for zeroout Shaohua Li <shli@fb.com> - 2016-05-26 20:10 +0200
  Re: [PATCH] block: correctly fallback for zeroout Christoph Hellwig <hch@infradead.org> - 2016-05-29 08:50 +0200

csiph-web