Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1408338
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] remove lots of IS_ERR_VALUE abuses |
| Date | 2016-05-28 00:10 +0200 |
| Message-ID | <rDy79-FP-45@gated-at.bofh.it> (permalink) |
| References | <rDxE5-e5-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, May 27, 2016 at 11:23:25PM +0200, Arnd Bergmann wrote:
> @@ -837,7 +837,7 @@ static int load_flat_shared_library(int id, struct lib_info *libs)
>
> res = prepare_binprm(&bprm);
>
> - if (!IS_ERR_VALUE(res))
> + if (res >= 0)
if (res == 0), please - prepare_binprm() returns 0 or -E...
> --- a/net/9p/client.c
> +++ b/net/9p/client.c
> @@ -521,7 +521,7 @@ static int p9_check_errors(struct p9_client *c, struct p9_req_t *req)
> if (p9_is_proto_dotu(c))
> err = -ecode;
>
> - if (!err || !IS_ERR_VALUE(err)) {
> + if (!err || !IS_ERR_VALUE((unsigned long)err)) {
Not really - it's actually
if (p9_is_proto_dotu(c) && ecode < 512)
err = -ecode;
if (!err) {
...
> @@ -608,7 +608,7 @@ static int p9_check_zc_errors(struct p9_client *c, struct p9_req_t *req,
> if (p9_is_proto_dotu(c))
> err = -ecode;
>
> - if (!err || !IS_ERR_VALUE(err)) {
> + if (!err || !IS_ERR_VALUE((unsigned long)err)) {
Ditto.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] remove lots of IS_ERR_VALUE abuses Arnd Bergmann <arnd@arndb.de> - 2016-05-27 23:40 +0200
Re: [PATCH] remove lots of IS_ERR_VALUE abuses Andrew Morton <akpm@linux-foundation.org> - 2016-05-27 23:50 +0200
Re: [PATCH] remove lots of IS_ERR_VALUE abuses Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-28 00:00 +0200
Re: [PATCH] remove lots of IS_ERR_VALUE abuses Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-28 00:10 +0200
Re: [PATCH] remove lots of IS_ERR_VALUE abuses Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-05-28 00:10 +0200
Re: [PATCH] remove lots of IS_ERR_VALUE abuses Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-28 01:30 +0200
csiph-web