Re: [GIT PULL] kbuild updates for v4.7-rc1

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] kbuild updates for v4.7-rc1
Date	2016-05-27 23:40 +0200
Message-ID	<rDxE5-e5-3@gated-at.bofh.it> (permalink)
References	<rDaet-2yj-3@gated-at.bofh.it> <rDweZ-7VA-7@gated-at.bofh.it> <rDwyn-82g-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Friday, May 27, 2016 1:20:29 PM CEST Linus Torvalds wrote:
> On Fri, May 27, 2016 at 1:04 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > In fact, the patch that I have in my private tree that was hiding the
> > warning for me on x86 is one that removes all instances of IS_ERR_VALUE()
> > with arguments other than 'unsigned long', see http://pastebin.com/uYa2mkgC
> > for reference.
> 
> Please just send me that patch, we need to do this (and then add a
> cast to pointer (and back to unsigned long) in IS_ERR_VALUE() so that
> we get warnings for when that macro is mis-used.

Ok, I've tried to come up with a summary of what happened so far
on this, and sent the patch your way, leaving out the modified
IS_ERR_VALUE() definition for the moment.

I've added the people on Cc whose drivers had the most invasive
changes.

> I didn't look at the details of your patch, but I did look at several
> IS_ERR_VALUE() uses in the standard kernel, and they were basically
> all wrong.

Yes, that matches what we found earlier this year when Andrzej Hajda
did some work on fixing the worst problems he found.

	Arnd

Thread

[GIT PULL] kbuild updates for v4.7-rc1 Michal Marek <mmarek@suse.com> - 2016-05-26 22:40 +0200
  Re: [GIT PULL] kbuild updates for v4.7-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-27 07:30 +0200
    Re: [GIT PULL] kbuild updates for v4.7-rc1 Arnd Bergmann <arnd@arndb.de> - 2016-05-27 14:40 +0200
      Re: [GIT PULL] kbuild updates for v4.7-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-27 19:30 +0200
        Re: [GIT PULL] kbuild updates for v4.7-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-27 20:30 +0200
        Re: [GIT PULL] kbuild updates for v4.7-rc1 Arnd Bergmann <arnd@arndb.de> - 2016-05-27 22:10 +0200
          Re: [GIT PULL] kbuild updates for v4.7-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-27 22:30 +0200
            Re: [GIT PULL] kbuild updates for v4.7-rc1 Arnd Bergmann <arnd@arndb.de> - 2016-05-27 23:40 +0200
            Re: [GIT PULL] kbuild updates for v4.7-rc1 Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-28 00:00 +0200

csiph-web