Re: [PATCH v4 3/4] iio: stx104: Allow build for X86_64

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/4] iio: stx104: Allow build for X86_64
Date	2016-05-27 20:30 +0200
Message-ID	<rDuGe-6SR-17@gated-at.bofh.it> (permalink)
References	<rC8y5-4qB-3@gated-at.bofh.it> <rC8y5-4qB-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 23, 2016 at 08:31:07PM -0400, William Breathitt Gray wrote:
> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
> drivers may be built for X86_64 architectures. This patch changes the
> ISA Kconfig option dependency of the Apex Embedded Systems STX104 DAC
> driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is
> expected to.
> 
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> ---
>  drivers/iio/dac/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index e63b957..315442f 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -247,7 +247,7 @@ config MCP4922
>  
>  config STX104
>  	tristate "Apex Embedded Systems STX104 DAC driver"
> -	depends on X86 && ISA
> +	depends on ISA_BUS_API

Assuming the dropped dependency on X86 is intentional:

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

>  	help
>  	  Say yes here to build support for the 2-channel DAC on the Apex
>  	  Embedded Systems STX104 integrated analog PC/104 card. The base port
> -- 
> 2.7.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thread

[PATCH v4 0/4] Allow ISA-style drivers on modern systems William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-05-24 02:40 +0200
  Re: [PATCH v4 2/4] gpio: Allow PC/104 devices on X86_64 Guenter Roeck <linux@roeck-us.net> - 2016-05-27 20:20 +0200
  Re: [PATCH v4 3/4] iio: stx104: Allow build for X86_64 Guenter Roeck <linux@roeck-us.net> - 2016-05-27 20:30 +0200
    Re: [PATCH v4 3/4] iio: stx104: Allow build for X86_64 William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-05-27 22:00 +0200
      Re: [PATCH v4 3/4] iio: stx104: Allow build for X86_64 Guenter Roeck <linux@roeck-us.net> - 2016-05-27 23:00 +0200

csiph-web