Re: [PATCH 2/2 V2] staging: dgnc: remove redundant null check in

From	Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2 V2] staging: dgnc: remove redundant null check in
Date	2016-05-27 12:30 +0200
Message-ID	<rDnbH-2bZ-5@gated-at.bofh.it> (permalink)
References	<rDf4t-5pr-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 27/05/16 02:43, Daeseok Youn wrote:
> the "brd" was already checked for NULL before calling dgnc_do_remap().
> 
> the dgnc_do_remap() function was called only
> from the dgnc_found_board() and the DGNC_BOARD_MAGIC value
> was assigned to "brd->magic" in dgcn_found_board(). So it doesn't
> need to check about magic value.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> V2: Adds more comments to Change Log.
> 
>  drivers/staging/dgnc/dgnc_driver.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index 22257d2..1882ef5 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -599,9 +599,6 @@ static int dgnc_finalize_board_init(struct dgnc_board *brd)
>   */
>  static void dgnc_do_remap(struct dgnc_board *brd)
>  {
> -	if (!brd || brd->magic != DGNC_BOARD_MAGIC)
> -		return;
> -
>  	brd->re_map_membase = ioremap(brd->membase, 0x1000);
>  }
>  
> 

Looks good.

Thanks for the fixes Daeseok :)

Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2 V2] staging: dgnc: remove redundant null check in Daeseok Youn <daeseok.youn@gmail.com> - 2016-05-27 03:50 +0200
  Re: [PATCH 2/2 V2] staging: dgnc: remove redundant null check in Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-05-27 12:30 +0200

csiph-web