Re: [PATCH] pinctrl: samsung: Suppress unbinding to prevent theoretical attacks

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: samsung: Suppress unbinding to prevent theoretical attacks
Date	2016-05-27 10:50 +0200
Message-ID	<rDlCW-18r-27@gated-at.bofh.it> (permalink)
References	<rzGmB-Pt-3@gated-at.bofh.it> <rCZsK-4u8-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/26/2016 11:08 AM, Linus Walleij wrote:
> On Tue, May 17, 2016 at 8:02 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
> 
>> Although unbinding a pinctrl driver requires root privileges but it
>> still might be used theoretically in certain attacks (by triggering NULL
>> pointer exception or memory corruption).
> 
> Patch applied with Javier's review tag.
> 
> I suspect this kind of patch should be done to a few
> GPIO controller :/

Probably yes... Either the driver properly and safely handles unbind
(remove() callback) or it should be forbidden. In the same time, even if
remove() is implemented, unbinding some of the core SoC drivers is like
shooting self in the foot.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: samsung: Suppress unbinding to prevent theoretical  attacks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-17 08:10 +0200
  Re: [PATCH] pinctrl: samsung: Suppress unbinding to prevent  theoretical attacks Javier Martinez Canillas <javier@osg.samsung.com> - 2016-05-21 04:40 +0200
  Re: [PATCH] pinctrl: samsung: Suppress unbinding to prevent  theoretical attacks Linus Walleij <linus.walleij@linaro.org> - 2016-05-26 11:10 +0200
    Re: [PATCH] pinctrl: samsung: Suppress unbinding to prevent  theoretical attacks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-27 10:50 +0200

csiph-web