Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform unwind

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform unwind
Date	2016-05-27 09:40 +0200
Message-ID	<rDkxb-uS-7@gated-at.bofh.it> (permalink)
References	<rCgOZ-1re-3@gated-at.bofh.it> <rCgP0-1re-41@gated-at.bofh.it> <rD7zY-Ud-27@gated-at.bofh.it> <rDkdP-ox-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 27, 2016 at 03:13:04PM +0800, Hekuang wrote:

SNIP

> >    - I understand we need to compile 3 objects from unwind-libunwind.c,
> >      how about we create 3 files like:
> > 
> >      util/unwind-libunwind-local.c
> >      util/unwind-libunwind-x86_32.c
> >      util/unwind-libunwind-arm64.c
> > 
> >      which would setup all necessary defines and include unwind-libunwind.c like:
> > 
> >      ---
> >      /* comments explaining every define ;-) */
> >      ...
> >      #define LOCAL... REMOTE..
> >      ...
> >      #include <util/unwind-libunwind-local.c>
> >      ...
> >      ----
> > 
> >      this way we will keep all the special setup for given unwind object
> >      in one place and you can also use simple rule in the Build file like
> >      without defining special rule:
> > 
> >      libperf-$(CONFIG_LIBUNWIND_X86)      += unwind-libunwind_x86_32.o
> >      libperf-$(CONFIG_LIBUNWIND_AARCH64)  += unwind-libunwind_arm64.o
> > 
> >      the same way for the arch object:
> > 
> >      arch/x86/util/unwind-libunwind-local.c
> >      arch/x86/util/unwind-libunwind-x86_32.c
> > 
> > 
> > Not sure I thought everything through, but I think this way
> > we'll keep it more maintainable and readable..
> > 
> > let me know what you think
> 
> The only concern is that, if later we support more platforms,
> there will be too much files named as 'tools/perf/util/unwind-libunwind*.c'
> Is it acceptable or not?
> 
> And I thought all files belongs to specific archs should
> go to folder under 'tools/perf/arch/xxx', is that right?

hum, I wouldn't worry about that.. but you're right,
let's put them under arch

thanks,
jirka

Thread

[PATCH v5 0/5] Add support for remote unwind He Kuang <hekuang@huawei.com> - 2016-05-24 11:30 +0200
  [PATCH v5 3/5] perf callchain: Add support for cross-platform unwind He Kuang <hekuang@huawei.com> - 2016-05-24 11:30 +0200
    Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform  unwind Jiri Olsa <jolsa@redhat.com> - 2016-05-26 19:50 +0200
      Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform  unwind Hekuang <hekuang@huawei.com> - 2016-05-27 09:20 +0200
        Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform  unwind Jiri Olsa <jolsa@redhat.com> - 2016-05-27 09:40 +0200
          Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform  unwind Hekuang <hekuang@huawei.com> - 2016-05-27 10:10 +0200
            Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform  unwind Jiri Olsa <jolsa@redhat.com> - 2016-05-27 10:50 +0200
    Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform  unwind Jiri Olsa <jolsa@redhat.com> - 2016-05-26 20:00 +0200
  [PATCH v5 4/5] perf callchain: Support x86 target platform He Kuang <hekuang@huawei.com> - 2016-05-24 11:30 +0200
    Re: [PATCH v5 4/5] perf callchain: Support x86 target platform Jiri Olsa <jolsa@redhat.com> - 2016-05-26 20:00 +0200
  [PATCH v5 2/5] perf tools: Show warnings for unsupported cross-platform unwind He Kuang <hekuang@huawei.com> - 2016-05-24 11:30 +0200

csiph-web