Re: [PATCH v3 5/6] mm/cma: remove MIGRATE_CMA

From	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 5/6] mm/cma: remove MIGRATE_CMA
Date	2016-05-27 07:40 +0200
Message-ID	<rDiF3-7NW-1@gated-at.bofh.it> (permalink)
References	<rCWXT-2Qp-5@gated-at.bofh.it> <rCWXT-2Qp-17@gated-at.bofh.it> <rDf4t-5pr-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 27, 2016 at 09:42:24AM +0800, Chen Feng wrote:
> Hi Joonsoo,
> > -/* Free whole pageblock and set its migration type to MIGRATE_CMA. */
> > +/* Free whole pageblock and set its migration type to MIGRATE_MOVABLE. */
> >  void __init init_cma_reserved_pageblock(struct page *page)
> >  {
> >  	unsigned i = pageblock_nr_pages;
> > @@ -1605,7 +1602,7 @@ void __init init_cma_reserved_pageblock(struct page *page)
> >  
> >  	adjust_present_page_count(page, pageblock_nr_pages);
> >  
> > -	set_pageblock_migratetype(page, MIGRATE_CMA);
> > +	set_pageblock_migratetype(page, MIGRATE_MOVABLE);
> 
> I have a question here, if the ZONE_CMA pages are all movable.
> 
> Then the unmovable alloc will also use CMA memory. Is this right?

No, previous patch changes that the CMA memory is on separate zone,
ZONE_CMA. We allow that zone when gfp is GFP_HIGHUSER_MOVABLE so
unmovable allocation cannot happen on CMA memory.

Thanks.

Thread

[PATCH v3 0/6] Introduce ZONE_CMA js1304@gmail.com - 2016-05-26 08:30 +0200
  [PATCH v3 3/6] mm/cma: populate ZONE_CMA js1304@gmail.com - 2016-05-26 08:30 +0200
  [PATCH v3 1/6] mm/page_alloc: recalculate some of zone threshold when on/offline memory js1304@gmail.com - 2016-05-26 08:30 +0200
  [PATCH v3 5/6] mm/cma: remove MIGRATE_CMA js1304@gmail.com - 2016-05-26 08:30 +0200
    Re: [PATCH v3 5/6] mm/cma: remove MIGRATE_CMA Chen Feng <puck.chen@hisilicon.com> - 2016-05-27 03:50 +0200
      Re: [PATCH v3 5/6] mm/cma: remove MIGRATE_CMA Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-05-27 07:40 +0200
  [PATCH v3 6/6] mm/cma: remove per zone CMA stat js1304@gmail.com - 2016-05-26 08:30 +0200
  Re: [PATCH v3 0/6] Introduce ZONE_CMA Feng Tang <feng.tang@intel.com> - 2016-05-26 10:10 +0200
    Re: [PATCH v3 0/6] Introduce ZONE_CMA Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-05-27 07:30 +0200
      Re: [PATCH v3 0/6] Introduce ZONE_CMA Feng Tang <feng.tang@intel.com> - 2016-05-27 08:30 +0200
        Re: [PATCH v3 0/6] Introduce ZONE_CMA Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-05-27 08:50 +0200
          Re: [PATCH v3 0/6] Introduce ZONE_CMA Feng Tang <feng.tang@intel.com> - 2016-05-27 09:30 +0200
            Re: [PATCH v3 0/6] Introduce ZONE_CMA Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-05-30 07:50 +0200

csiph-web