[PATCH] ACPICA / hardware: Fix address check in acpi_hw_get_access_bit_width()

From	Lv Zheng <lv.zheng@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH] ACPICA / hardware: Fix address check in acpi_hw_get_access_bit_width()
Date	2016-05-27 05:50 +0200
Message-ID	<rDgWC-6Eh-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The address check in acpi_hw_get_access_bit_width() should be byte size
based, not bit width based. This patch fixes this mistake.

Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
 drivers/acpi/acpica/hwregs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpica/hwregs.c b/drivers/acpi/acpica/hwregs.c
index 0f18dbc..74a591b 100644
--- a/drivers/acpi/acpica/hwregs.c
+++ b/drivers/acpi/acpica/hwregs.c
@@ -95,7 +95,7 @@ acpi_hw_get_access_bit_width(struct acpi_generic_address *reg, u8 max_bit_width)
 		if (!reg->bit_offset && reg->bit_width &&
 		    ACPI_IS_POWER_OF_TWO(reg->bit_width) &&
 		    ACPI_IS_ALIGNED(reg->bit_width, 8) &&
-		    ACPI_IS_ALIGNED(address, reg->bit_width)) {
+		    ACPI_IS_ALIGNED(address, reg->bit_width >> 3)) {
 			return (reg->bit_width);
 		} else {
 			if (reg->space_id == ACPI_ADR_SPACE_SYSTEM_IO) {
-- 
1.7.10

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ACPICA / hardware: Fix address check in acpi_hw_get_access_bit_width() Lv Zheng <lv.zheng@intel.com> - 2016-05-27 05:50 +0200
  RE: [PATCH] ACPICA / hardware: Fix address check in  acpi_hw_get_access_bit_width() "Zheng, Lv" <lv.zheng@intel.com> - 2016-05-27 06:00 +0200

csiph-web