Re: [RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit

From	Shawn Lin <shawn.lin@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit
Date	2016-05-27 04:30 +0200
Message-ID	<rDfHb-5Zl-1@gated-at.bofh.it> (permalink)
References	<rDei5-4TY-3@gated-at.bofh.it> <rCTQl-U1-3@gated-at.bofh.it> <rDei5-4TY-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

在 2016/5/27 8:53, Jaehoon Chung 写道:
> Hi Shawn,
>
> On 05/26/2016 12:07 PM, Shawn Lin wrote:
>> dw_mci_get_cd have already dealed with these for
>> both of internal card-detect and gpio card-detect.
>
> s/dealed/dealt
>
> This patch looks good to me. Could you resend the patch? not RFC.
>

Ok.

> Best Regards,
> Jaehoon Chung
>
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>
>> ---
>>
>>  drivers/mmc/host/dw_mmc.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index 829a6ee..cb30e91 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
>>  		mmc->max_seg_size = mmc->max_req_size;
>>  	}
>>
>> -	if (dw_mci_get_cd(mmc))
>> -		set_bit(DW_MMC_CARD_PRESENT, &slot->flags);
>> -	else
>> -		clear_bit(DW_MMC_CARD_PRESENT, &slot->flags);
>> +	dw_mci_get_cd(mmc);
>>
>>  	ret = mmc_add_host(mmc);
>>  	if (ret)
>>
>
>
>
>


-- 
Best Regards
Shawn Lin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-26 05:10 +0200
  Re: [RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and  clear_bit Jaehoon Chung <jh80.chung@samsung.com> - 2016-05-27 03:00 +0200
    Re: [RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and  clear_bit Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-27 04:30 +0200

csiph-web