Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1408505

Re: [PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage

Show all headers | View raw

Hi Kieran,

On Fri, May 27, 2016 at 7:19 PM, Kieran Bingham <kieran@ksquared.org.uk> wrote:
> The example misses the power-domains usage, and documentation that the
> property is used by the node.
>
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>

Thanks for your patch!

> ---
>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> index 1c0718b501ef..464bb7ae4b92 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> @@ -21,6 +21,8 @@ are paired with. These DT bindings currently support the FCPV and FCPF.
>
>   - reg: the register base and size for the device registers
>   - clocks: Reference to the functional clock
> + - power-domains : power-domain property defined with a phandle
> +                           to respective power domain.

I'd write "power domain specifier" instead of "phandle". While SYSC on R-Car
Gen3 uses #power-domain-cells = 0, the FCP module may show up on another
SoC that uses a different value, needing more than just a phandle.

In fact I'm inclined to leave out the power-domains property completely:
it's not a feature of the FCP, but of the SoC the FCP is part of.
power-domains properties may appear in any device node where needed.

>  Device node example
> @@ -30,4 +32,5 @@ Device node example
>                 compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>                 reg = <0 0xfea2f000 0 0x200>;
>                 clocks = <&cpg CPG_MOD 602>;
> +               power-domains = <&sysc R8A7795_PD_A3VP>;

Adding it to the example doesn't hurt, though.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] RCar r8a7795 FCPF support Kieran Bingham <kieran@ksquared.org.uk> - 2016-05-27 19:20 +0200
  [PATCH 1/4] fcp: Extend FCP compatible list to support the FDP Kieran Bingham <kieran@ksquared.org.uk> - 2016-05-27 19:20 +0200
    Re: [PATCH 1/4] fcp: Extend FCP compatible list to support the FDP Kieran Bingham <kieran@ksquared.org.uk> - 2016-05-27 19:30 +0200
  [PATCH 1/4] v4l: Extend FCP compatible list to support the FDP Kieran Bingham <kieran@ksquared.org.uk> - 2016-05-27 19:30 +0200
  [PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage Kieran Bingham <kieran@ksquared.org.uk> - 2016-05-27 19:30 +0200
    Re: [PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-28 21:10 +0200
      Re: [PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains  usage Kieran Bingham <kieran@ksquared.org.uk> - 2016-05-30 12:10 +0200
  [PATCH 4/4] arm64: dts: r8a7795: add FCPF device nodes Kieran Bingham <kieran@ksquared.org.uk> - 2016-05-27 19:30 +0200
  [PATCH 2/4] dt-bindings: Update Renesas R-Car FCP DT binding Kieran Bingham <kieran@ksquared.org.uk> - 2016-05-27 19:30 +0200
    Re: [PATCH 2/4] dt-bindings: Update Renesas R-Car FCP DT binding Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-28 21:10 +0200
      Re: [PATCH 2/4] dt-bindings: Update Renesas R-Car FCP DT binding Kieran Bingham <kieran@ksquared.org.uk> - 2016-05-30 12:10 +0200

csiph-web