Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1408501
| From | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mtd: brcmnand: Add v7.2 controller support |
| Date | 2016-05-28 20:10 +0200 |
| Message-ID | <rDQQq-3LB-9@gated-at.bofh.it> (permalink) |
| References | <rDxXs-ni-21@gated-at.bofh.it> |
| Organization | Free Electrons |
Hello, On Fri, 27 May 2016 14:58:11 -0700, Florian Fainelli wrote: > + if (ctrl->nand_version >= 0x0702) > + bits = 7; > if (ctrl->nand_version >= 0x0600) Don't you want an "else if" here ? Otherwise, even for the 7.2 version of your controller bits will be set to 1. Ditto when setting ctrl->max_oob. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] mtd: brcmnand: Add v7.2 controller support Florian Fainelli <f.fainelli@gmail.com> - 2016-05-28 00:00 +0200 Re: [PATCH] mtd: brcmnand: Add v7.2 controller support Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-05-28 20:10 +0200
csiph-web