Re: [PATCH 3/3] pvclock: Add a new wrapper function to only get variable flags

From	Minfei Huang <mnghuan@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] pvclock: Add a new wrapper function to only get variable flags
Date	2016-05-28 14:10 +0200
Message-ID	<rDLe2-kx-19@gated-at.bofh.it> (permalink)
References	<rDjhL-8fO-5@gated-at.bofh.it> <rDjhL-8fO-3@gated-at.bofh.it> <rDsbn-5gf-5@gated-at.bofh.it> <rDsuJ-5E6-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/27/16 at 06:06P, Paolo Bonzini wrote:
> 
> 
> On 27/05/2016 17:40, Andy Lutomirski wrote:
> > On Thu, May 26, 2016 at 11:17 PM, Minfei Huang <mnghuan@gmail.com> wrote:
> >> There is a generic function __pvclock_read_cycles to be used to get both
> >> flags and cycles. For function pvclock_read_flags, it's useless to get
> >> cycles value. To make this function be more effective, add a new wrapper
> >> function to only get variable flags.
> > 
> > Why not just get rid of this function entirely?
> 
> I agree.  If you want to abstract the retry logic, perhaps you can add

Hmm, I will get rid of pvclock_read_flags, and repost it.

Thanks
Minfei

> pvclock_read_{begin,retry} functions like seqlock_read_{begin,retry}?
> 
> Thanks,
> 
> Paolo

Thread

[PATCH 3/3] pvclock: Add a new wrapper function to only get variable flags Minfei Huang <mnghuan@gmail.com> - 2016-05-27 08:20 +0200
  Re: [PATCH 3/3] pvclock: Add a new wrapper function to only get  variable flags Andy Lutomirski <luto@amacapital.net> - 2016-05-27 17:50 +0200
    Re: [PATCH 3/3] pvclock: Add a new wrapper function to only get  variable flags Paolo Bonzini <pbonzini@redhat.com> - 2016-05-27 18:10 +0200
      Re: [PATCH 3/3] pvclock: Add a new wrapper function to only get  variable flags Minfei Huang <mnghuan@gmail.com> - 2016-05-28 14:10 +0200
  [PATCH 3/3 V2] pvclock: Get rid of __pvclock_read_cycles in function pvclock_read_flags Minfei Huang <mnghuan@gmail.com> - 2016-05-28 14:30 +0200

csiph-web