Re: [PATCH 3/3] arm64/numa: fix type info

From	Ganapatrao Kulkarni <gpkulkarni@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] arm64/numa: fix type info
Date	2016-05-26 18:30 +0200
Message-ID	<rD6ky-dV-13@gated-at.bofh.it> (permalink)
References	<rCTwZ-wH-3@gated-at.bofh.it> <rCTwZ-wH-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 25, 2016 at 7:43 PM, Zhen Lei <thunder.leizhen@huawei.com> wrote:
> numa_init(of_numa_init) may returned error because of numa configuration
> error. So "No NUMA configuration found" is inaccurate. In fact, specific
> configuration error information can be immediately printed by the
> testing branch. So "No NUMA..." only needs to be printed when numa_off.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  arch/arm64/mm/numa.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
> index 98dc104..9937cc1 100644
> --- a/arch/arm64/mm/numa.c
> +++ b/arch/arm64/mm/numa.c
> @@ -362,7 +362,8 @@ static int __init dummy_numa_init(void)
>         int ret;
>         struct memblock_region *mblk;
>
> -       pr_info("%s\n", "No NUMA configuration found");
> +       if (numa_off)

IIRC, it should be
if (!numa_off)
we want to print this message when we failed to find proper numa configuration.
when numa_off is set, we will not look for any numa configuration.

> +               pr_info("%s\n", "No NUMA configuration found");
>         pr_info("NUMA: Faking a node at [mem %#018Lx-%#018Lx]\n",
>                0LLU, PFN_PHYS(max_pfn) - 1);
>
> --
> 2.5.0

ganapat
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Thread

[PATCH 3/3] arm64/numa: fix type info Zhen Lei <thunder.leizhen@huawei.com> - 2016-05-26 04:50 +0200
  Re: [PATCH 3/3] arm64/numa: fix type info Ganapatrao Kulkarni <gpkulkarni@gmail.com> - 2016-05-26 18:30 +0200
    Re: [PATCH 3/3] arm64/numa: fix type info Joe Perches <joe@perches.com> - 2016-05-26 18:40 +0200
      Re: [PATCH 3/3] arm64/numa: fix type info David Daney <ddaney.cavm@gmail.com> - 2016-05-26 19:20 +0200
        Re: [PATCH 3/3] arm64/numa: fix type info "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-05-27 04:40 +0200

csiph-web