Re: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.

From	Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.
Date	2016-05-26 14:40 +0200
Message-ID	<rD2JX-6r8-11@gated-at.bofh.it> (permalink)
References	<rCYwG-3W0-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 26/05/16 09:01, Shubham Bansal wrote:
> Fixed a coding style issue. Issue reported by checkpatch.pl.
> 
> Signed-off-by: Shubham Bansal <illusionist.neo@gmail.com>
> ---
>  drivers/staging/android/ion/ion.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 8536567..2217ccb 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -184,7 +184,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
>  	struct scatterlist *sg;
>  	int i, ret;
>  
> -	buffer = kzalloc(sizeof(struct ion_buffer), GFP_KERNEL);
> +	buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
>  	if (!buffer)
>  		return ERR_PTR(-ENOMEM);
>  
> 


This patch looks good.

It is not a big issue, but have it in mind for the future. When fixing issues
reported by checkpatch, it is nice to paste the output warning of checkpatch
in the commit message.

Look at this example:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=e7a142aaa09fa5db015fd176d6943f888665829f

Thanks,
Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: android: ion: fixed a kzalloc coding style issue. Shubham Bansal <illusionist.neo@gmail.com> - 2016-05-26 10:10 +0200
  Re: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue. Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-05-26 14:40 +0200

csiph-web