Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1407527

Re: [PATCH v2] f2fs: Return the errno to the caller to avoid using a wrong page

From Yunlong Song <yunlong.song@huawei.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] f2fs: Return the errno to the caller to avoid using a wrong page
Date 2016-05-26 13:40 +0200
Message-ID <rD1NU-5QI-11@gated-at.bofh.it> (permalink)
References <rCGzL-14D-11@gated-at.bofh.it> <rCVfs-1EH-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


>  page_hit:
> -	f2fs_bug_on(sbi, nid != nid_of_node(page));
> +	if(nid != nid_of_node(page)) {

should add "unlikely" here, will fix this in v3 patch.

> +		f2fs_bug_on(sbi, 1);
> +		ClearPageUptodate(page);
> +out_err:
> +		f2fs_put_page(page, 1);
> +		return ERR_PTR(-EIO);
> +	}
>  	return page;
>  }
>  
> 


-- 
Thanks,
Yunlong Song

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] f2fs: Return the errno to the caller to avoid using a wrong page Yunlong Song <yunlong.song@huawei.com> - 2016-05-25 15:00 +0200
  Re: [PATCH] f2fs: Return the errno to the caller to avoid using a  wrong page Jaegeuk Kim <jaegeuk@kernel.org> - 2016-05-25 19:00 +0200
    Re: [PATCH] f2fs: Return the errno to the caller to avoid using a  wrong page Yunlong Song <yunlong.song@huawei.com> - 2016-05-27 14:30 +0200
  [PATCH v2] f2fs: Return the errno to the caller to avoid using a wrong page Yunlong Song <yunlong.song@huawei.com> - 2016-05-26 06:40 +0200
    Re: [PATCH v2] f2fs: Return the errno to the caller to avoid using a  wrong page Yunlong Song <yunlong.song@huawei.com> - 2016-05-26 13:40 +0200
  [PATCH v3] f2fs: Return the errno to the caller to avoid using a wrong page Yunlong Song <yunlong.song@huawei.com> - 2016-05-26 13:40 +0200

csiph-web