Re: [PATCH v1 1/3] Add the latent_entropy gcc plugin

From	Emese Revfy <re.emese@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 1/3] Add the latent_entropy gcc plugin
Date	2016-05-24 23:20 +0200
Message-ID	<rCrU6-cB-19@gated-at.bofh.it> (permalink)
References	<rC6cW-39y-23@gated-at.bofh.it> <rC6cW-39y-21@gated-at.bofh.it> <rCotc-6fG-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 24 May 2016 10:32:15 -0700
Kees Cook <keescook@chromium.org> wrote:

> Also, does this matter that it's non-atomic? It seems like the u64
> below is being written to by multiple threads and even read by
> multiple threads. Am I misunderstanding something?

The non-atomic accesses are intentional because
they can extract more latent entropy from these data races.
 
> > [...]
> > new file mode 100644
> > index 0000000..7295c39
> > --- /dev/null
> > +++ b/scripts/gcc-plugins/latent_entropy_plugin.c
> 
> I feel like most of the functions in this plugin could use some more
> comments about what each one does.

I think the important parts are commented (most parts just use the gcc API).
Where would you like more comments?

-- 
Emese

Thread

[PATCH v1 0/3] Introduce the latent_entropy gcc plugin Emese Revfy <re.emese@gmail.com> - 2016-05-24 00:10 +0200
  [PATCH v1 1/3] Add the latent_entropy gcc plugin Emese Revfy <re.emese@gmail.com> - 2016-05-24 00:10 +0200
    Re: [PATCH v1 1/3] Add the latent_entropy gcc plugin Kees Cook <keescook@chromium.org> - 2016-05-24 19:40 +0200
      Re: [PATCH v1 1/3] Add the latent_entropy gcc plugin Emese Revfy <re.emese@gmail.com> - 2016-05-24 23:20 +0200
      Re: [PATCH v1 1/3] Add the latent_entropy gcc plugin "PaX Team" <pageexec@freemail.hu> - 2016-05-25 01:50 +0200
        Re: [PATCH v1 1/3] Add the latent_entropy gcc plugin Kees Cook <keescook@chromium.org> - 2016-05-25 05:00 +0200
          Re: [PATCH v1 1/3] Add the latent_entropy gcc plugin Emese Revfy <re.emese@gmail.com> - 2016-05-31 00:40 +0200
  [PATCH v1 2/3] Mark functions with the latent_entropy attribute Emese Revfy <re.emese@gmail.com> - 2016-05-24 00:10 +0200
    Re: [PATCH v1 2/3] Mark functions with the latent_entropy attribute Kees Cook <keescook@chromium.org> - 2016-05-24 19:20 +0200
      Re: [PATCH v1 2/3] Mark functions with the latent_entropy attribute Emese Revfy <re.emese@gmail.com> - 2016-05-24 22:40 +0200
        Re: [PATCH v1 2/3] Mark functions with the latent_entropy attribute Kees Cook <keescook@chromium.org> - 2016-05-24 23:00 +0200
  [PATCH v1 3/3] Add the extra_latent_entropy kernel parameter Emese Revfy <re.emese@gmail.com> - 2016-05-24 00:20 +0200
    Re: [PATCH v1 3/3] Add the extra_latent_entropy kernel parameter Kees Cook <keescook@chromium.org> - 2016-05-24 19:10 +0200
      Re: [PATCH v1 3/3] Add the extra_latent_entropy kernel parameter Emese Revfy <re.emese@gmail.com> - 2016-05-24 22:30 +0200

csiph-web