Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1406225

Re: [PATCH] usb: core: add debugobjects support for urb object

Show all headers | View raw

On Tue, May 24, 2016 at 03:53:53PM +0800, changbin.du@intel.com wrote:
> From: "Du, Changbin" <changbin.du@intel.com>
> 
> Add debugobject support to track the life time of struct urb.
> This feature help us detect violation of urb operations by
> generating a warning message from debugobject core. And we fix
> the possible issues at runtime to avoid oops if we can.
> 
> I have done some tests with some class drivers, no violation
> found in them which is good. Expect this feature can be used
> for debugging future problems.
> 
> Signed-off-by: Du, Changbin <changbin.du@intel.com>

I agree with Alan, what use is this code?  Existing drivers all work
properly because the reference counting of urbs is already present, why
add duplicate counters?  That actually leads to bugs.  I don't see the
need for this code, please explain it better if you wish for it to be
accepted.  What has it found/fixed that we have not found yet?  What
does it allow you to do that you can't do today with the existing code?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: core: add debugobjects support for urb object changbin.du@intel.com - 2016-05-24 10:10 +0200
  Re: [PATCH] usb: core: add debugobjects support for urb object Alan Stern <stern@rowland.harvard.edu> - 2016-05-24 16:30 +0200
  Re: [PATCH] usb: core: add debugobjects support for urb object Greg KH <gregkh@linuxfoundation.org> - 2016-05-24 16:50 +0200
    RE: [PATCH] usb: core: add debugobjects support for urb object "Du, Changbin" <changbin.du@intel.com> - 2016-05-26 04:20 +0200

csiph-web