Re: [PATCH 1/3] iio: st_sensors: Init trigger before irq request

From	Crestez Dan Leonard <leonard.crestez@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] iio: st_sensors: Init trigger before irq request
Date	2016-05-24 14:40 +0200
Message-ID	<rCjMS-3fX-13@gated-at.bofh.it> (permalink)
References	<ryqjU-Jw-3@gated-at.bofh.it> <rCiH8-2BC-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/24/2016 02:27 PM, Linus Walleij wrote:
> On Fri, May 13, 2016 at 8:43 PM, Crestez Dan Leonard
> <leonard.crestez@intel.com> wrote:
> 
>> This fixes a possible race where an interrupt arrives before complete
>> initialization and crashes because iio_trigger_get_drvdata returns NULL.
>>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Giuseppe Barba <giuseppe.barba@st.com>
>> Cc: Denis Ciocca <denis.ciocca@st.com>
>> Signed-off-by: Crestez Dan Leonard <leonard.crestez@intel.com>
>> ---
>> I ran into this while breaking the driver. But since the interrupt line can be
>> shared the handler should always be able to accept and ignore a call.
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> However I think my patch fixing the thread issue will collide
> by being close in context to this so it'd be great if you
> could resend it on top of
> "iio: st_sensors: switch to a threaded interrupt"?

I checked my local git tree and this was already on top of v6 of that
patch. I think this issue is much less likely to cause problems without
it. Perhaps it should be incorporated into your patch?

I'll resend if it causes conflicts for Jonathan.

-- 
Regards,
Leonard

Thread

[PATCH 1/3] iio: st_sensors: Init trigger before irq request Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-05-13 20:50 +0200
  [PATCH 3/3] iio: st_sensors: Use level interrupts Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-05-13 20:50 +0200
    Re: [PATCH 3/3] iio: st_sensors: Use level interrupts Jonathan Cameron <jic23@kernel.org> - 2016-05-14 18:20 +0200
    Re: [PATCH 3/3] iio: st_sensors: Use level interrupts Linus Walleij <linus.walleij@linaro.org> - 2016-05-24 13:50 +0200
      Re: [PATCH 3/3] iio: st_sensors: Use level interrupts Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-05-24 14:40 +0200
        Re: [PATCH 3/3] iio: st_sensors: Use level interrupts Jonathan Cameron <jic23@kernel.org> - 2016-05-29 21:30 +0200
  [PATCH 2/3] iio: st_sensors: Disable DRDY at init time Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-05-13 20:50 +0200
    Re: [PATCH 2/3] iio: st_sensors: Disable DRDY at init time Jonathan Cameron <jic23@kernel.org> - 2016-05-14 19:00 +0200
    Re: [PATCH 2/3] iio: st_sensors: Disable DRDY at init time Linus Walleij <linus.walleij@linaro.org> - 2016-05-24 13:30 +0200
      Re: [PATCH 2/3] iio: st_sensors: Disable DRDY at init time Jonathan Cameron <jic23@kernel.org> - 2016-05-29 21:30 +0200
  Re: [PATCH 1/3] iio: st_sensors: Init trigger before irq request Jonathan Cameron <jic23@kernel.org> - 2016-05-14 19:00 +0200
  Re: [PATCH 1/3] iio: st_sensors: Init trigger before irq request Linus Walleij <linus.walleij@linaro.org> - 2016-05-24 13:30 +0200
    Re: [PATCH 1/3] iio: st_sensors: Init trigger before irq request Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-05-24 14:40 +0200
      Re: [PATCH 1/3] iio: st_sensors: Init trigger before irq request Linus Walleij <linus.walleij@linaro.org> - 2016-05-25 00:00 +0200
        Re: [PATCH 1/3] iio: st_sensors: Init trigger before irq request Jonathan Cameron <jic23@kernel.org> - 2016-05-29 21:30 +0200

csiph-web