Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1406051

[PATCH] genirq: Fix missing return value in irq_destroy_ipi()

Show all headers | View raw

Commit 7cec18a3906b ("genirq: Add error code reporting to
irq_{reserve,destroy}_ipi") changed the return type of irq_destroy_ipi
to int, but missed adding a value to one return statement. Fix this to
silence the resultant compiler warning:

kernel/irq/ipi.c In function ‘irq_destroy_ipi’:
kernel/irq/ipi.c:128:3: warning: ‘return’ with no value, in function returning non-void [-Wreturn-type]
  return;
  ^
Fixes: 7cec18a3906b ("genirq: Add error code reporting to
irq_{reserve,destroy}_ipi")
Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>

---

 kernel/irq/ipi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/ipi.c b/kernel/irq/ipi.c
index c42742208e5e..89b49f6773f0 100644
--- a/kernel/irq/ipi.c
+++ b/kernel/irq/ipi.c
@@ -125,7 +125,7 @@ int irq_destroy_ipi(unsigned int irq, const struct cpumask *dest)
 
 	domain = data->domain;
 	if (WARN_ON(domain == NULL))
-		return;
+		return -EINVAL;
 
 	if (!irq_domain_is_ipi(domain)) {
 		pr_warn("Trying to destroy a non IPI domain!\n");
-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] genirq: Fix missing return value in irq_destroy_ipi() Matt Redfearn <matt.redfearn@imgtec.com> - 2016-05-24 12:50 +0200
  [tip:irq/urgent] genirq: Fix missing return value in  irq_destroy_ipi() tip-bot for Matt Redfearn <tipbot@zytor.com> - 2016-05-24 15:50 +0200

csiph-web