Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1406002

[PATCH 2/2] perf record: Fix crash when kptr is restricted

Show all headers | View raw

Before this patch, a simple 'perf record' could fail if kptr_restrict
is set to 1 (for normal user) or 2 (for root):

 # perf record ls
 WARNING: Kernel address maps (/proc/{kallsyms,modules}) are restricted,
 check /proc/sys/kernel/kptr_restrict.

 Samples in kernel functions may not be resolved if a suitable vmlinux
 file is not found in the buildid cache or in the vmlinux path.

 Samples in kernel modules won't be resolved at all.

 If some relocation was applied (e.g. kexec) symbols may be misresolved
 even with a suitable vmlinux or kallsyms file.

 Segmentation fault (core dumped)

This patch skips perf_event__synthesize_kernel_mmap() when kptr is not
available.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
---
 tools/perf/util/event.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index f6fcc68..9b141f1 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -673,6 +673,8 @@ int perf_event__synthesize_kernel_mmap(struct perf_tool *tool,
 	int err;
 	union perf_event *event;
 
+	if (symbol_conf.kptr_restrict)
+		return -1;
 	if (map == NULL)
 		return -1;
 
-- 
1.8.3.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] perf tools: Check kptr_restrict for root Wang Nan <wangnan0@huawei.com> - 2016-05-24 11:30 +0200
  [PATCH 2/2] perf record: Fix crash when kptr is restricted Wang Nan <wangnan0@huawei.com> - 2016-05-24 11:40 +0200
    Re: [PATCH 2/2] perf record: Fix crash when kptr is restricted Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-24 14:30 +0200
    Re: [PATCH 2/2] perf record: Fix crash when kptr is restricted Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-24 14:50 +0200
    [tip:perf/urgent] perf record: Fix crash when kptr is restricted tip-bot for Wang Nan <tipbot@zytor.com> - 2016-05-29 20:30 +0200
  Re: [PATCH 1/2] perf tools: Check kptr_restrict for root Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-24 14:30 +0200
  [tip:perf/urgent] perf symbols: Check kptr_restrict for root tip-bot for Wang Nan <tipbot@zytor.com> - 2016-05-29 20:20 +0200

csiph-web