Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1405985

Re: [PATCH] hwrng: stm32 - fix build warning

From Maxime Coquelin <mcoquelin.stm32@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] hwrng: stm32 - fix build warning
Date 2016-05-24 11:30 +0200
Message-ID <rCgOZ-1re-5@gated-at.bofh.it> (permalink)
References <rC1Gi-gw-13@gated-at.bofh.it> <rCg2C-Ve-9@gated-at.bofh.it> <rCgm3-12f-29@gated-at.bofh.it> <rCgm3-12f-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

2016-05-24 10:58 GMT+02:00 Arnd Bergmann <arnd@arndb.de>:
> On Tuesday, May 24, 2016 10:50:17 AM CEST Maxime Coquelin wrote:
>> diff --git a/drivers/char/hw_random/stm32-rng.c
>> b/drivers/char/hw_random/stm32-rng.c
>> index 92a810648bd0..2a0fc90e4dc3 100644
>> --- a/drivers/char/hw_random/stm32-rng.c
>> +++ b/drivers/char/hw_random/stm32-rng.c
>> @@ -68,6 +68,10 @@ static int stm32_rng_read(struct hwrng *rng, void
>> *data, size_t max, bool wait)
>>                         } while (!sr && --timeout);
>>                 }
>>
>> +               if (WARN_ONCE(sr & (RNG_SR_SEIS | RNG_SR_CEIS),
>> +                               "bad RNG status - %x\n", sr))
>> +                       writel_relaxed(0, priv->base + RNG_SR);
>> +
>>                 /* If error detected or data not ready... */
>>                 if (sr != RNG_SR_DRDY)
>>                         break;
>> @@ -79,10 +83,6 @@ static int stm32_rng_read(struct hwrng *rng, void
>> *data, size_t max, bool wait)
>>                 max -= sizeof(u32);
>>         }
>>
>> -       if (WARN_ONCE(sr & (RNG_SR_SEIS | RNG_SR_CEIS),
>> -                     "bad RNG status - %x\n", sr))
>> -               writel_relaxed(0, priv->base + RNG_SR);
>> -
>>         pm_runtime_mark_last_busy((struct device *) priv->rng.priv);
>>         pm_runtime_put_sync_autosuspend((struct device *) priv->rng.priv);
>>
>> Thanks,
>>
>
> Yes, that looks good to me.

Thanks!
Sudip, do you want to send the patch, or I manage to do it?

Maxime

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] hwrng: stm32 - fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-05-23 19:20 +0200
  Re: [PATCH] hwrng: stm32 - fix build warning Arnd Bergmann <arnd@arndb.de> - 2016-05-23 22:40 +0200
    Re: [PATCH] hwrng: stm32 - fix build warning Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-05-24 10:00 +0200
      Re: [PATCH] hwrng: stm32 - fix build warning Arnd Bergmann <arnd@arndb.de> - 2016-05-24 10:40 +0200
        Re: [PATCH] hwrng: stm32 - fix build warning Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-05-24 11:00 +0200
          Re: [PATCH] hwrng: stm32 - fix build warning Arnd Bergmann <arnd@arndb.de> - 2016-05-24 11:00 +0200
            Re: [PATCH] hwrng: stm32 - fix build warning Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-05-24 11:30 +0200
              Re: [PATCH] hwrng: stm32 - fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-05-25 08:40 +0200
          Re: [PATCH] hwrng: stm32 - fix build warning Daniel Thompson <daniel.thompson@linaro.org> - 2016-05-24 12:10 +0200
            Re: [PATCH] hwrng: stm32 - fix build warning Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-05-24 13:00 +0200
    Re: [PATCH] hwrng: stm32 - fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-05-25 08:40 +0200
      Re: [PATCH] hwrng: stm32 - fix build warning Arnd Bergmann <arnd@arndb.de> - 2016-05-25 12:10 +0200
        Re: [PATCH] hwrng: stm32 - fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-05-27 15:40 +0200

csiph-web