Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1405917

RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process

From "Li, Liang Z" <liang.z.li@intel.com>
Newsgroups linux.kernel
Subject RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process
Date 2016-05-24 10:00 +0200
Message-ID <rCfpT-sX-1@gated-at.bofh.it> (permalink)
References <rAPxv-4bk-5@gated-at.bofh.it> <rAQMV-4QX-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> On 20/05/2016 11:59, Liang Li wrote:
> > +
> > +		sg_init_table(sg, 5);
> > +		sg_set_buf(&sg[0], &flags, sizeof(flags));
> > +		sg_set_buf(&sg[1], &start_pfn, sizeof(start_pfn));
> > +		sg_set_buf(&sg[2], &page_shift, sizeof(page_shift));
> > +		sg_set_buf(&sg[3], &bmap_len, sizeof(bmap_len));
> 
> These four should probably be placed in a single struct and therefore a single
> sg entry.  It might even be faster to place it together with the bitmap, thus
> avoiding the use of indirect descriptors.
> 

Yes, thanks for your suggestion.

> You should also test ballooning of a 64GB guest after filling in the page cache,
> not just ballooning of a freshly booted 4GB guest.  This will give you a much
> more sparse bitmap.  Still, the improvement in sending PFNs to the host are

I will include the test result for that case in next version.


Thanks,

Liang

> impressive.
> 
> Thanks,
> 
> Paolo
> 
> > +		sg_set_buf(&sg[4], vb->page_bitmap +
> > +				 (start_pfn / BITS_PER_LONG), bmap_len);
> > +		virtqueue_add_outbuf(vq, sg, 5, vb, GFP_KERNEL);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC kernel] balloon: speed up inflating/deflating process Liang Li <liang.z.li@intel.com> - 2016-05-20 12:10 +0200
  Re: [PATCH RFC kernel] balloon: speed up inflating/deflating process Paolo Bonzini <pbonzini@redhat.com> - 2016-05-20 13:30 +0200
    RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Li, Liang Z" <liang.z.li@intel.com> - 2016-05-24 10:00 +0200
  Re: [PATCH RFC kernel] balloon: speed up inflating/deflating  process Cornelia Huck <cornelia.huck@de.ibm.com> - 2016-05-20 13:30 +0200
    RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Li, Liang Z" <liang.z.li@intel.com> - 2016-05-24 09:50 +0200
  Re: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Michael S. Tsirkin" <mst@redhat.com> - 2016-05-20 14:10 +0200
    RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Li, Liang Z" <liang.z.li@intel.com> - 2016-05-24 12:00 +0200
    RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Li, Liang Z" <liang.z.li@intel.com> - 2016-05-24 12:00 +0200
      Re: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Michael S. Tsirkin" <mst@redhat.com> - 2016-05-24 12:10 +0200
        RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Li, Liang Z" <liang.z.li@intel.com> - 2016-05-24 12:40 +0200
          Re: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Michael S. Tsirkin" <mst@redhat.com> - 2016-05-24 13:20 +0200
            RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Li, Liang Z" <liang.z.li@intel.com> - 2016-05-24 16:40 +0200
              Re: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Michael S. Tsirkin" <mst@redhat.com> - 2016-05-24 17:20 +0200
                RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Li, Liang Z" <liang.z.li@intel.com> - 2016-05-25 03:00 +0200
                RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Li, Liang Z" <liang.z.li@intel.com> - 2016-05-25 03:10 +0200
                Re: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Michael S. Tsirkin" <mst@redhat.com> - 2016-05-25 10:40 +0200
        RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Li, Liang Z" <liang.z.li@intel.com> - 2016-05-25 10:50 +0200
          Re: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Michael S. Tsirkin" <mst@redhat.com> - 2016-05-25 11:00 +0200
            RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Li, Liang Z" <liang.z.li@intel.com> - 2016-05-25 11:30 +0200
              Re: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Michael S. Tsirkin" <mst@redhat.com> - 2016-05-25 11:50 +0200
                RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Li, Liang Z" <liang.z.li@intel.com> - 2016-05-25 12:20 +0200
                Re: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Michael S. Tsirkin" <mst@redhat.com> - 2016-05-25 12:40 +0200
                RE: [PATCH RFC kernel] balloon: speed up inflating/deflating process "Li, Liang Z" <liang.z.li@intel.com> - 2016-05-25 16:40 +0200

csiph-web