Re: [PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v5

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Heiko Stuebner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v5
Date	Tue, 24 May 2016 10:30:01 +0200
Message-ID	<rCfSV-RZ-17@gated-at.bofh.it> (permalink)
References	<rCeWR-h0-3@gated-at.bofh.it> <rCeWR-h0-1@gated-at.bofh.it>
X-Original-To	Tomeu Vizoso <tomeu.vizoso@collabora.com>
User-Agent	KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Mark Yao <mark.yao@rock-chips.com>, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org
X-Original-Date	Tue, 24 May 2016 10:28:42 +0200
X-Original-Message-ID	<7363560.k3ytHeYgtM@phil>
X-Original-References	<1464074761-5194-1-git-send-email-tomeu.vizoso@collabora.com> <1464074857-5515-1-git-send-email-tomeu.vizoso@collabora.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1405934

Show key headers only | View raw

Hi Tomeu,

Patch subject: please put the version into the brackets, so [PATCH v5] as it 
shouldn't be part of the commit log.

Am Dienstag, 24. Mai 2016, 09:27:37 schrieb Tomeu Vizoso:
> As per the docs, atomic_commit should return -EBUSY "if an asycnhronous
> updated is requested and there is an earlier updated pending".

> v2: Use the status of the workqueue instead of vop->event, and don't add
> a superfluous wait on the workqueue.
> 
> v3: Drop work_busy, as there's a sizeable delay when the worker
> finishes, which introduces a race in which the client has already
> received the last flip event but the next page flip ioctl will still
> return -EBUSY because work_busy returns outdated information.
> 
> v4: Hold dev->event_lock while checking the VOP's event field as
> suggested by Daniel Stone.
> 
> v5: Only block if there's outstanding work if it's a blocking call.

similarly, please put the changelog below the "---" and above the diffstat.


> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---

aka here.

>  drivers/gpu/drm/rockchip/rockchip_drm_drv.h |  1 +
>  drivers/gpu/drm/rockchip/rockchip_drm_fb.c  | 25
> ++++++++++++++++++++++--- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 
> 6 ++++++
>  3 files changed, 29 insertions(+), 3 deletions(-)

Heiko

Thread

[PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v5 Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2016-05-24 09:30 +0200
  Re: [PATCH] drm/rockchip: Return -EBUSY if there's already a pending  flip event v5 Daniel Stone <daniel@fooishbar.org> - 2016-05-24 09:40 +0200
  Re: [PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v5 Heiko Stuebner <heiko@sntech.de> - 2016-05-24 10:30 +0200
    Re: [PATCH] drm/rockchip: Return -EBUSY if there's already a pending  flip event v5 Daniel Vetter <daniel@ffwll.ch> - 2016-05-24 10:40 +0200
      Re: [PATCH] drm/rockchip: Return -EBUSY if there's already a pending  flip event v5 Daniel Vetter <daniel@ffwll.ch> - 2016-05-24 10:40 +0200
        Re: [PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v5 Heiko Stuebner <heiko@sntech.de> - 2016-05-24 10:50 +0200
          Re: [PATCH] drm/rockchip: Return -EBUSY if there's already a pending  flip event v5 Daniel Vetter <daniel@ffwll.ch> - 2016-05-24 11:10 +0200

csiph-web