Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1405811

Re: [PATCH v2] ip_tunnel: enclose a code block in macro IS_ENABLED(CONFIG_IPV6)

Show all headers | View raw

On Tue, 2016-05-24 at 10:39 +0800, Haishuang Yan wrote:
> For ipv6 case, enclose the code block in macro IS_ENABLED(CONFIG_IPV6).
> 
> ---
> Changes in v2:
>   - Place the "#if IS_ENABLED" block before the "} else if
> (..) {" piece and the "#endif" before the closing brace and this
> becomes much easier to look at.

_Why_ is this patch needed ?

Please describe in the changelog what _actual_ problem you are trying to
address.

We have many points in the kernel using ipv6_get_dsfield() even if
CONFIG_IPV6=n, and it seems fine to me at least.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] ip_tunnel: enclose a code block in macro IS_ENABLED(CONFIG_IPV6) Haishuang Yan <yanhaishuang@cmss.chinamobile.com> - 2016-05-24 04:50 +0200
  Re: [PATCH v2] ip_tunnel: enclose a code block in macro  IS_ENABLED(CONFIG_IPV6) Eric Dumazet <eric.dumazet@gmail.com> - 2016-05-24 05:20 +0200
    Re: [PATCH v2] ip_tunnel: enclose a code block in macro IS_ENABLED(CONFIG_IPV6) 严海双 <yanhaishuang@cmss.chinamobile.com> - 2016-05-24 06:00 +0200
      Re: [PATCH v2] ip_tunnel: enclose a code block in macro  IS_ENABLED(CONFIG_IPV6) David Miller <davem@davemloft.net> - 2016-05-24 06:10 +0200

csiph-web