Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests
Date	2016-05-24 05:10 +0200
Message-ID	<rCaTf-61D-1@gated-at.bofh.it> (permalink)
References	<rC3yp-1sr-7@gated-at.bofh.it> <rC7Vo-3YJ-15@gated-at.bofh.it> <rC9Nw-54N-5@gated-at.bofh.it> <rCa6S-5we-7@gated-at.bofh.it> <rCaqe-5CJ-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 23, 2016 at 10:32:43PM -0400, Steven Rostedt wrote:
> On Tue, 24 May 2016 11:16:31 +0900
> Namhyung Kim <namhyung@kernel.org> wrote:
> 
> 
> > Why not checking "hist" file then?
> 
> I guess that could be done too, but is there anything wrong with my
> current solution? Or is it just too hacky? How would one check if
> something exists in a file or not? Say, I want to detect if
> preemptirqsoff tracer exists or not, and that only happens if I do a
> grep of current_tracer (I have tests coming that will need to do that)?

There's nothing wrong with your approach IMHO.  But I think checking
existence of a file is clearer and consistent to other tests.

For the preemptirqsoff tracer case, it seems there's no other way to
check it simply.  It's not hacky to me grep-ing contents to check
availability of some option.

Thanks,
Namhyung

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC][PATCH] ftracetest: Fix hist unsupported result in hist  selftests Steven Rostedt <rostedt@goodmis.org> - 2016-05-23 21:20 +0200
  Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist  selftests Namhyung Kim <namhyung@kernel.org> - 2016-05-24 02:00 +0200
    Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist  selftests Steven Rostedt <rostedt@goodmis.org> - 2016-05-24 04:00 +0200
      Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist  selftests Namhyung Kim <namhyung@kernel.org> - 2016-05-24 04:20 +0200
        Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist  selftests Steven Rostedt <rostedt@goodmis.org> - 2016-05-24 04:40 +0200
          Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist  selftests Namhyung Kim <namhyung@kernel.org> - 2016-05-24 05:10 +0200

csiph-web