Re: [PATCH 2/4] hwrng: bcm2835: Support Broadcom NSP SoC rng

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] hwrng: bcm2835: Support Broadcom NSP SoC rng
Date	Tue, 24 May 2016 04:20:02 +0200
Message-ID	<rCa6S-5we-3@gated-at.bofh.it> (permalink)
References	<rC0TU-8cl-7@gated-at.bofh.it> <rC0TU-8cl-5@gated-at.bofh.it>
X-Original-To	Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Stephen Warren <swarren@wwwdotorg.org>, Lee Jones <lee@kernel.org>, Russell King <linux@arm.linux.org.uk>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, Jon Mason <jonmason@broadcom.com>, Matt Mackall <mpm@selenic.com>, Herbert Xu <herbert@gondor.apana.org.au>, Daniel Thompson <daniel.thompson@linaro.org>, Kieran Bingham <kieranbingham@gmail.com>, Pankaj Dev <pankaj.dev@st.com>, Richard Weinberger <richard@nod.at>, noltari@gmail.com, Joshua Henderson <joshua.henderson@microchip.com>
User-Agent	Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-crypto@vger.kernel.org, Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
X-Original-Date	Mon, 23 May 2016 19:14:09 -0700
X-Original-Message-ID	<87oa7w2oem.fsf@eliezer.anholt.net>
X-Original-References	<1464020451-16520-1-git-send-email-yendapally.reddy@broadcom.com> <1464020451-16520-3-git-send-email-yendapally.reddy@broadcom.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1405777

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
writes:

> This supports the random number generator available in NSP SoC.
> Masks the rng interrupt for NSP.

The interrupt reg is also present on the 2835.  I would prefer for
simplicity if you also initialized the register to the same value on the
Pi, even though the firmware has presumably been setting it for us
already.

However, this patch is still correct and I'm fine with it, so it's:

Acked-by: Eric Anholt <eric@anholt.net>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] hwrng: bcm2835: Support Broadcom NSP SoC rng Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com> - 2016-05-23 18:30 +0200
  Re: [PATCH 2/4] hwrng: bcm2835: Support Broadcom NSP SoC rng Eric Anholt <eric@anholt.net> - 2016-05-24 04:20 +0200

csiph-web