Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1407412

Re: [PATCH] blk-mq: clear q->mq_ops if init fail

Show all headers | View raw

On Wed, May 25, 2016 at 11:23:27PM -0700, Ming Lin wrote:
> From: Ming Lin <ming.l@samsung.com>
> 
> blk_mq_init_queue() calls blk_mq_init_allocated_queue(), but q->mq_ops
> was not cleared when blk_mq_init_allocated_queue() fails.
> Then blk_cleanup_queue() calls blk_mq_free_queue() which will crash because:
> - q->all_q_node is not added to all_q_list yet
> - q->tag_set is NULL
> - hctx was not setup yet or already freed
> 
> Fixed it by clearing q->mq_ops on error path.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] blk-mq: clear q->mq_ops if init fail Ming Lin <mlin@kernel.org> - 2016-05-26 08:30 +0200
  Re: [PATCH] blk-mq: clear q->mq_ops if init fail Christoph Hellwig <hch@lst.de> - 2016-05-26 09:10 +0200
  Re: [PATCH] blk-mq: clear q->mq_ops if init fail Jens Axboe <axboe@kernel.dk> - 2016-05-26 17:00 +0200

csiph-web