[Regression?] iptables broken on 32bit with pre-4.7-rc

From	John Stultz <john.stultz@linaro.org>
Newsgroups	linux.kernel
Subject	[Regression?] iptables broken on 32bit with pre-4.7-rc
Date	2016-05-26 08:00 +0200
Message-ID	<rCWuS-2rd-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hey Florian, Pablo,

In updating a 32bit arm device from 4.6 to Linus' current HEAD, I
noticed I was having some trouble with networking, and realized that
/proc/net/ip_tables_names was suddenly empty.

Digging through the registration process, it seems we're catching on the:

       if (strcmp(t->u.user.name, XT_STANDARD_TARGET) == 0 &&
           target_offset + sizeof(struct xt_standard_target) != next_offset)
               return -EINVAL;

check added in 7ed2abddd20cf ("netfilter: x_tables: check standard
target size too").

Where next_offset seems to be 4 bytes larger then the the offset +
standard_target struct size.

Commenting out those checks (the commit doesn't revert cleanly), seems
to get things going again for me.

I'm not exactly sure how the next_offset value is set, so I'm hoping
the proper fix is more obvious to one of you.

thanks
-john

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[Regression?] iptables broken on 32bit with pre-4.7-rc John Stultz <john.stultz@linaro.org> - 2016-05-26 08:00 +0200
  Re: [Regression?] iptables broken on 32bit with pre-4.7-rc Florian Westphal <fw@strlen.de> - 2016-05-26 12:00 +0200
    Re: [Regression?] iptables broken on 32bit with pre-4.7-rc John Stultz <john.stultz@linaro.org> - 2016-05-26 23:10 +0200

csiph-web