Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1407369

[PATCH] fs: Do not check for valid page->mapping in page_cache_pipe_buf_confirm

Show all headers | View raw

If the page is truncated after being spliced into the pipe, it's
probably not invalid.

For filesystems that invalidate pages, we used to return -ENODATA
even though the data is there, it's just possibly different from
what was spliced into the pipe. We shouldn't have to throw away
the buffer or return error in this case.

Signed-off-by: Abhi Das <adas@redhat.com>
CC: Miklos Szeredi <mszeredi@redhat.com>
CC: Jens Axboe <axboe@fb.com>
CC: Al Viro <viro@zeniv.linux.org.uk>
---
 fs/splice.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/fs/splice.c b/fs/splice.c
index dd9bf7e..b9899b99 100644
--- a/fs/splice.c
+++ b/fs/splice.c
@@ -106,15 +106,6 @@ static int page_cache_pipe_buf_confirm(struct pipe_inode_info *pipe,
 		lock_page(page);
 
 		/*
-		 * Page got truncated/unhashed. This will cause a 0-byte
-		 * splice, if this is the first page.
-		 */
-		if (!page->mapping) {
-			err = -ENODATA;
-			goto error;
-		}
-
-		/*
 		 * Uh oh, read-error from disk.
 		 */
 		if (!PageUptodate(page)) {
-- 
2.4.3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] fs: Do not check for valid page->mapping in page_cache_pipe_buf_confirm Abhi Das <adas@redhat.com> - 2016-05-26 05:30 +0200

csiph-web