Re: [PATCH 1/2] Revert "mtd: atmel_nand: Support variable RB_EDGE interrupts"

Path	csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] Revert "mtd: atmel_nand: Support variable RB_EDGE interrupts"
Date	Thu, 26 May 2016 05:20:02 +0200
Message-ID	<rCU02-Xi-7@gated-at.bofh.it> (permalink)
References	<rwNkC-7Aw-13@gated-at.bofh.it> <rwNkD-7Aw-37@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ctgoW/0zQ/sI6xk7dbazTu2dgazPS+rivaiIdc+dX1I=; b=Z0kIZy76fV1cPvoaQDYDnggpAFZ/YzBiihSSHSY+0H6PMShGJPzoc6I5yMt6l5QA+E gdkXrqi7xtXJyKQAihUS6+U5c/YCkKbuJaHnhSDP9b6ZPTx8SmYool/UHkZHFdvFRlMw F95GJg3CgDZ135lTFp6vIm1DQfYxhNPx8aLc1+VLpaEKrOV/PMYirhgxsdJ0CxsizrXO RMw+M1Sqss57DxvH1Wguq4f1esMvkru3v8P278wj3/f47wD0nj59VV69V02AQ2qZCTmS n/v6pNz/4VXMJ5QTzQr344v6xFiHGYdQ5h+8w8zinK9Ow5RxWk4HhoO9iB2sRyz+jLc0 zYnw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ctgoW/0zQ/sI6xk7dbazTu2dgazPS+rivaiIdc+dX1I=; b=AAtoQcPifsCpUJMkRYzMfEom0eamda5UEhvVDtkFPtod4HTQq7gklcixaGsvZ6Ue0t RiVhdPQeZTQIKt3wPP9e2NWoljlHasFm7YPFrjWqil++7uGMuSCo83BptIeFlEA9hPcg X9GMCN637HNMOYR4UzjNP1Ll4Wmx/ob6otsxGpkQ/LnlNrZf6yFDcM+n6fnpS0pxHdCD 6BEjr0ku8XnUxfmVpt7JD/7D3+QiwfemmWOXazBvgiY3pk0vzbC/K3K+F3HmQXm8lGCj vLBpKn9li15OlPPc7VGpQ9aqP4bEURVeQOvHBOUw5vLz6aFiJ/pG19xPXBSWBhsFp10m khFQ==
X-Gm-Message-State	ALyK8tLOSXUYszqbMTzYJGE5A6eIQqh2fUTlojpnnRil8CeXhfF2nA7VyVnIqx+k/gu39Q==
X-Received	by 10.66.150.232 with SMTP id ul8mr10131277pab.85.1464232617872; Wed, 25 May 2016 20:16:57 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
Organization	linux.* mail to news gateway
X-Original-Cc	David Woodhouse <dwmw2@infradead.org>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Brown <broonie@kernel.org>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, Nicolas Ferre <nicolas.ferre@atmel.com>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Russell King <linux@arm.linux.org.uk>, Josh Wu <rainyfeeling@outlook.com>, linux-arm-kernel@lists.infradead.org
X-Original-Date	Wed, 25 May 2016 20:16:54 -0700
X-Original-Message-ID	<20160526031654.GA107505@google.com>
X-Original-References	<1462776680-5284-1-git-send-email-wenyou.yang@atmel.com> <1462776680-5284-2-git-send-email-wenyou.yang@atmel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1407367

Show key headers only | View raw

Hi,

On Mon, May 09, 2016 at 02:51:18PM +0800, Wenyou Yang wrote:
> This reverts commit 5ddc7bd43ccc ("mtd: atmel_nand: Support variable
> RB_EDGE interrupts")
> 
> Because for current SoCs, the RB_EDGE3(i.e. bit 27) of HSMC_SR
> register does not exist, the RB_EDGE0 (i.e. bit 24) is the ready/busy
> line edge status bit. It is a datasheet bug.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
> 
>  .../devicetree/bindings/mtd/atmel-nand.txt         |  2 +-
>  drivers/mtd/nand/atmel_nand.c                      | 35 +++++-----------------
>  drivers/mtd/nand/atmel_nand_nfc.h                  |  3 +-
>  3 files changed, 10 insertions(+), 30 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/atmel-nand.txt b/Documentation/devicetree/bindings/mtd/atmel-nand.txt
> index d53aba9..3e7ee99 100644
> --- a/Documentation/devicetree/bindings/mtd/atmel-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/atmel-nand.txt
> @@ -39,7 +39,7 @@ Optional properties:
>  
>  Nand Flash Controller(NFC) is an optional sub-node
>  Required properties:
> -- compatible : "atmel,sama5d3-nfc" or "atmel,sama5d4-nfc".
> +- compatible : "atmel,sama5d3-nfc".
>  - reg : should specify the address and size used for NFC command registers,
>          NFC registers and NFC SRAM. NFC SRAM address and size can be absent
>          if don't want to use it.
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index efc8ea2..68b9160 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
[...]
>  static const struct of_device_id atmel_nand_nfc_match[] = {
> -	{ .compatible = "atmel,sama5d3-nfc", .data = &sama5d3_nfc_caps },
> -	{ .compatible = "atmel,sama5d4-nfc", .data = &sama5d4_nfc_caps },
> +	{ .compatible = "atmel,sama5d3-nfc" },

Hmm, wait. Didn't Rob and Alexandre suggest that we should *not* drop
the compatible property? We could have easily supported both here, and
just not listed any different capabilities. But I see that Nicholas took
the patch anyway, so I guess it's not a big deal...

>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, atmel_nand_nfc_match);

Brian

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] Revert "mtd: atmel_nand: Support variable RB_EDGE  interrupts" Brian Norris <computersforpeace@gmail.com> - 2016-05-26 05:20 +0200
  Re: [PATCH 1/2] Revert "mtd: atmel_nand: Support variable RB_EDGE  interrupts" Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-05-26 08:40 +0200

csiph-web