Re: [PATCH v6] platform:x86: Add PMC Driver for Intel Core SoC

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6] platform:x86: Add PMC Driver for Intel Core SoC
Date	2016-05-25 23:10 +0200
Message-ID	<rCOdY-5Pr-21@gated-at.bofh.it> (permalink)
References	<rCL6p-3OI-9@gated-at.bofh.it> <rCNrz-5jO-9@gated-at.bofh.it> <rCO4h-5ww-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 25, 2016 at 11:37:21PM +0300, Andy Shevchenko wrote:
> On Wed, May 25, 2016 at 11:13 PM, Darren Hart <dvhart@infradead.org> wrote:
> > On Wed, May 25, 2016 at 11:14:52PM +0530, Rajneesh Bhardwaj wrote:
> 
> > Hi Rajneesh,
> >
> > Unfortunately during my build test, this introduced a new warning to the build:
> >
> > drivers/platform/x86/intel_pmc_core.c:201:19: warning: ‘intel_pmc_core_init’
> > defined but not used [-Wunused-function]
> >  static int __init intel_pmc_core_init(void)
> >
> > After the removal of the module stuff, the driver needed a device_initcall, or
> > the macro equivalent, consider:
> >
> > $ git diff
> > diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> > index c834281..f6a29b9 100644
> > --- a/drivers/platform/x86/intel_pmc_core.c
> > +++ b/drivers/platform/x86/intel_pmc_core.c
> > @@ -198,7 +198,4 @@ static struct pci_driver intel_pmc_core_driver = {
> 
> >         .remove = NULL, /* not a hot-plug capable driver */
> 
> Since it requires an update I would suggest to remove above line completely.

Indeed, thank you Andy.

-- 
Darren Hart
Intel Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6] platform:x86: Add PMC Driver for Intel Core SoC Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> - 2016-05-25 19:50 +0200
  Re: [PATCH v6] platform:x86: Add PMC Driver for Intel Core SoC Darren Hart <dvhart@infradead.org> - 2016-05-25 22:20 +0200
    Re: [PATCH v6] platform:x86: Add PMC Driver for Intel Core SoC Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-05-25 23:00 +0200
      Re: [PATCH v6] platform:x86: Add PMC Driver for Intel Core SoC Darren Hart <dvhart@infradead.org> - 2016-05-25 23:10 +0200

csiph-web