Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1406869

Re: [PATCH 1/6] drm: sun4i: do cleanup if RGB output init fails

From Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/6] drm: sun4i: do cleanup if RGB output init fails
Date 2016-05-25 14:40 +0200
Message-ID <rCGgp-Yf-15@gated-at.bofh.it> (permalink)
References <rzPzz-6rL-15@gated-at.bofh.it> <rzPzA-6rL-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Tue, May 17, 2016 at 11:56:06PM +0800, Chen-Yu Tsai wrote:
> sun4i_rgb_init() can fail, which results in TCON failing to bind.
> In this case we need to do cleanup, specificly unregistering the
> dotclock, which is regmap based, and the regmap is registered as
> part of the sun4i_tcon_bind().
> 
> Failing to do so results in a NULL pointer reference when the CCF
> tries to turn off unused clocks.
> 
> Fixes: 29e57fab97fc ("drm: sun4i: Add RGB output")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] ARM: dts: sun5i: q8-common: Enable various peripherals Chen-Yu Tsai <wens@csie.org> - 2016-05-17 18:00 +0200
  [PATCH 6/6] ARM: dts: sun5i: q8-common: Enable display pipeline and LCD display Chen-Yu Tsai <wens@csie.org> - 2016-05-17 18:00 +0200
    Re: [PATCH 6/6] ARM: dts: sun5i: q8-common: Enable display pipeline  and LCD display Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-25 14:50 +0200
  [PATCH 5/6] ARM: dts: sun5i: q8-common: Enable audio codec Chen-Yu Tsai <wens@csie.org> - 2016-05-17 18:00 +0200
    Re: [PATCH 5/6] ARM: dts: sun5i: q8-common: Enable audio codec Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-25 14:50 +0200
  [PATCH 1/6] drm: sun4i: do cleanup if RGB output init fails Chen-Yu Tsai <wens@csie.org> - 2016-05-17 18:00 +0200
    Re: [PATCH 1/6] drm: sun4i: do cleanup if RGB output init fails Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-25 14:40 +0200
  [PATCH 3/6] ARM: dts: sun5i: q8-common: Enable USB-based WiFi Chen-Yu Tsai <wens@csie.org> - 2016-05-17 18:00 +0200
  [PATCH 2/6] ARM: dts: axp209: Disable ldo5 by default Chen-Yu Tsai <wens@csie.org> - 2016-05-17 18:00 +0200
    Re: [PATCH 2/6] ARM: dts: axp209: Disable ldo5 by default Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-25 14:40 +0200
  Re: [PATCH 0/6] ARM: dts: sun5i: q8-common: Enable various  peripherals Hans de Goede <hdegoede@redhat.com> - 2016-05-18 10:20 +0200
    Re: [PATCH 0/6] ARM: dts: sun5i: q8-common: Enable various  peripherals Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-25 14:50 +0200

csiph-web