Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1406853
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it |
| Date | 2016-05-25 13:40 +0200 |
| Message-ID | <rCFkm-qt-9@gated-at.bofh.it> (permalink) |
| References | <rCtjb-Ur-9@gated-at.bofh.it> <rCtjc-Ur-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, May 24, 2016 at 03:48:41PM -0700, Andy Lutomirski wrote:
> This will help debug OOPSes related to USER_DS vs KERNEL_DS.
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> arch/x86/kernel/dumpstack_32.c | 4 ++++
> arch/x86/kernel/dumpstack_64.c | 5 +++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/arch/x86/kernel/dumpstack_32.c b/arch/x86/kernel/dumpstack_32.c
> index 464ffd69b92e..5dbb08fd8291 100644
> --- a/arch/x86/kernel/dumpstack_32.c
> +++ b/arch/x86/kernel/dumpstack_32.c
> @@ -124,8 +124,12 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs,
> void show_regs(struct pt_regs *regs)
> {
> int i;
> + struct thread_info *ti = current_thread_info();
>
> show_regs_print_info(KERN_EMERG);
> + if (ti->addr_limit.seg != TASK_SIZE_MAX)
> + printk(KERN_DEFAULT "task.addr_limit: 0x%lx\n",
> + ti->addr_limit.seg);
I guess we can dump that unconditionally just to be consistent and so
that all oopses look the same, i.e., with that line always present.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it Andy Lutomirski <luto@kernel.org> - 2016-05-25 00:50 +0200
Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it Borislav Petkov <bp@alien8.de> - 2016-05-25 13:40 +0200
Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it Andy Lutomirski <luto@amacapital.net> - 2016-05-29 18:50 +0200
Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it Boris Petkov <bp@alien8.de> - 2016-05-29 20:50 +0200
Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it Andy Lutomirski <luto@amacapital.net> - 2016-05-29 21:10 +0200
Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it Borislav Petkov <bp@alien8.de> - 2016-05-30 09:50 +0200
Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it Borislav Petkov <bp@alien8.de> - 2016-05-25 13:40 +0200
Re: [PATCH 4/7] x86/dumpstack: If addr_limit is non-default, display it Andy Lutomirski <luto@amacapital.net> - 2016-05-29 18:50 +0200
csiph-web