Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1406831
| From | Daniel Baluta <daniel.baluta@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 6/7] iio: adc: ad7923: use iio helper function to guarantee direct mode |
| Date | 2016-05-25 12:50 +0200 |
| Message-ID | <rCExY-8n2-11@gated-at.bofh.it> (permalink) |
| References | <rCq1X-7jq-3@gated-at.bofh.it> <rCqbE-7np-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, May 24, 2016 at 10:19 PM, Alison Schofield <amsfield22@gmail.com> wrote:
> Replace the code that guarantees the device stays in direct mode
> with iio_device_claim_direct_mode() which does same.
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@gmail.com>
> ---
> drivers/iio/adc/ad7923.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c
> index 45e29cc..ff444c1 100644
> --- a/drivers/iio/adc/ad7923.c
> +++ b/drivers/iio/adc/ad7923.c
> @@ -233,12 +233,11 @@ static int ad7923_read_raw(struct iio_dev *indio_dev,
>
> switch (m) {
> case IIO_CHAN_INFO_RAW:
> - mutex_lock(&indio_dev->mlock);
> - if (iio_buffer_enabled(indio_dev))
> - ret = -EBUSY;
> - else
> - ret = ad7923_scan_direct(st, chan->address);
> - mutex_unlock(&indio_dev->mlock);
> + ret = iio_device_claim_direct_mode(indio_dev);
> + if (ret)
> + return ret;
> + ret = ad7923_scan_direct(st, chan->address);
> + iio_device_release_direct_mode(indio_dev);
>
> if (ret < 0)
> return ret;
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] iio: adc: clean up claims on direct mode in ad7* drivers Alison Schofield <amsfield22@gmail.com> - 2016-05-24 21:20 +0200
[PATCH 4/7] iio: adc: ad7476: use iio helper function to guarantee direct mode Alison Schofield <amsfield22@gmail.com> - 2016-05-24 21:20 +0200
Re: [PATCH 4/7] iio: adc: ad7476: use iio helper function to guarantee direct mode Daniel Baluta <daniel.baluta@gmail.com> - 2016-05-25 12:40 +0200
Re: [PATCH 4/7] iio: adc: ad7476: use iio helper function to guarantee direct mode Jonathan Cameron <jic23@kernel.org> - 2016-05-29 20:40 +0200
[PATCH 1/7] iio: adc: ad7266: claim direct mode during sensor read Alison Schofield <amsfield22@gmail.com> - 2016-05-24 21:20 +0200
Re: [PATCH 1/7] iio: adc: ad7266: claim direct mode during sensor read Daniel Baluta <daniel.baluta@gmail.com> - 2016-05-25 12:40 +0200
Re: [PATCH 1/7] iio: adc: ad7266: claim direct mode during sensor read Jonathan Cameron <jic23@kernel.org> - 2016-05-29 19:10 +0200
[PATCH 5/7] iio: adc: ad7887: use iio helper function to guarantee direct mode Alison Schofield <amsfield22@gmail.com> - 2016-05-24 21:20 +0200
Re: [PATCH 5/7] iio: adc: ad7887: use iio helper function to guarantee direct mode Daniel Baluta <daniel.baluta@gmail.com> - 2016-05-25 12:40 +0200
Re: [PATCH 5/7] iio: adc: ad7887: use iio helper function to guarantee direct mode Jonathan Cameron <jic23@kernel.org> - 2016-05-29 20:40 +0200
[PATCH 6/7] iio: adc: ad7923: use iio helper function to guarantee direct mode Alison Schofield <amsfield22@gmail.com> - 2016-05-24 21:30 +0200
Re: [PATCH 6/7] iio: adc: ad7923: use iio helper function to guarantee direct mode Daniel Baluta <daniel.baluta@gmail.com> - 2016-05-25 12:50 +0200
Re: [PATCH 6/7] iio: adc: ad7923: use iio helper function to guarantee direct mode Jonathan Cameron <jic23@kernel.org> - 2016-05-29 20:40 +0200
[PATCH 7/7] iio: adc: ad799x: use iio helper function to guarantee direct mode Alison Schofield <amsfield22@gmail.com> - 2016-05-24 21:30 +0200
Re: [PATCH 7/7] iio: adc: ad799x: use iio helper function to guarantee direct mode Daniel Baluta <daniel.baluta@gmail.com> - 2016-05-25 12:50 +0200
Re: [PATCH 7/7] iio: adc: ad799x: use iio helper function to guarantee direct mode Jonathan Cameron <jic23@kernel.org> - 2016-05-29 20:40 +0200
csiph-web