Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1405754

Re: [PATCH 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation

Show all headers | View raw

Hi Rob,

Thanks for your review !

On Mon, May 23, 2016 at 1:30 PM, Rob Herring <robh@kernel.org> wrote:
>
> On Mon, May 16, 2016 at 09:17:25AM -0700, Hoan Tran wrote:
> > This patch adds the APM X-Gene hwmon device tree node documentation.
> >
> > Signed-off-by: Hoan Tran <hotran@apm.com>
> > ---
> >  .../devicetree/bindings/hwmon/apm-xgene-hwmon.txt          | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt b/Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
> > new file mode 100644
> > index 0000000..49a482e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/apm-xgene-hwmon.txt
> > @@ -0,0 +1,14 @@
> > +APM X-Gene hwmon driver
> > +
> > +Hwmon driver accesses sensors over the "SLIMpro" mailbox.
>
> DT bindings describe h/w, not driver data.
How about this description: "APM X-Gene SOC sensors are accessed over
the "SLIMpro" mailbox" ?
> I'm not sure this belongs in
> DT and perhaps the devices for the mailbox should be created by the
> mailbox driver.
I don't think the current mailbox supports it.
>
> > +
> > +Required properties :
> > + - compatible : should be "apm,xgene-slimpro-hwmon"
> > + - mboxes : use the label reference for the mailbox as the first parameter.
> > +         The second parameter is the channel number.
>
> When do you expect this to be different mailbox numbers?
No, this number is not changed. This "mboxes" property is used and
required by mailbox.c when hwmon driver requests a mailbox channel

Thanks and Regards
Hoan
>
>
> > +
> > +Example :
> > +     hwmonslimpro {
> > +             compatible = "apm,xgene-slimpro-hwmon";
> > +             mboxes = <&mailbox 7>;
> > +     };
> > --
> > 1.9.1
> >

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Add support for X-Gene hwmon driver Hoan Tran <hotran@apm.com> - 2016-05-16 18:20 +0200
  [PATCH 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation Hoan Tran <hotran@apm.com> - 2016-05-16 18:20 +0200
    Re: [PATCH 1/3] Documentation: dtb: xgene: Add hwmon dts binding  documentation Rob Herring <robh@kernel.org> - 2016-05-23 22:40 +0200
      Re: [PATCH 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation Hoan Tran <hotran@apm.com> - 2016-05-24 03:10 +0200
        Re: [PATCH 1/3] Documentation: dtb: xgene: Add hwmon dts binding  documentation Rob Herring <robh@kernel.org> - 2016-05-25 19:10 +0200
  [PATCH 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree Hoan Tran <hotran@apm.com> - 2016-05-16 18:20 +0200
  [PATCH 2/3] hwmon: xgene: Adds hwmon driver Hoan Tran <hotran@apm.com> - 2016-05-16 18:20 +0200
    Re: [2/3] hwmon: xgene: Adds hwmon driver Guenter Roeck <linux@roeck-us.net> - 2016-05-30 07:30 +0200

csiph-web