Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1405666

Re: livepatch: Avoid possible race when releasing the patch

Show all headers | View raw

+++ Petr Mladek [23/05/16 17:54 +0200]:
>There was a long discussion about a possible race with sysfs, kobjects
>when removing an unused livepatch, see
>https://lkml.kernel.org/g/%3C1462190242-24731-1-git-send-email-mbenes@suse.cz%3E
>
>This patch set tries to implement what looked the most preferred solution
>from the discussion. I did my best to keep the patch definition simple.
>But I am not super happy with the result.
>
>I send the current state before I spent even more time on different
>approaches.
>
>I personally think that we might get better result if we declare
>some limited structures, define them statically and then copy all
>data into the final structures in a single call. I did not implement
>this because it was weird on the first look but I am not sure now.
>
>But even more I would prefer the solution with the completion.
>It is already used by the module framework. It does not look
>that hacky to me after all.

Hi Petr, thanks a lot for the RFC and for exploring this possible
solution. I haven't reviewed the patches thoroughly yet, but at first
glance I admit that I did not think through how much this approach
would complicate the livepatch API, and the new intermediary functions
do seem like overkill in response to the original kobject problem..

I looked at how the module loader used the completion, and in fact
it is used to remedy a nearly identical problem with
DEBUG_KOBJ_RELEASE (see commit 942e443 "Fix mod->mkobj.kobj
potentially freed too early"), and Miroslav's original solution pretty
much took the same approach. We could even mirror that approach and
have something like klp_kobject_put() (much like mod_kobject_put()) to
package up the kobject_put/wait_for_completion calls, but that is
purely a matter of taste.

Anyway, I am just beginning to lean towards the completion solution
again (sorry for jumping back and forth :-/), but we can play with
this patchset a bit more and see if we can come up with something
reasonable.

Thanks,
Jessica

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH  0/2] livepatch: Avoid possible race when releasing the patch Petr Mladek <pmladek@suse.com> - 2016-05-23 18:00 +0200
  [RFC PATCH  2/2] livepatch: Use kobjects the right way Petr Mladek <pmladek@suse.com> - 2016-05-23 18:00 +0200
  Re: [RFC PATCH  0/2] livepatch: Avoid possible race when releasing  the patch Josh Poimboeuf <jpoimboe@redhat.com> - 2016-05-23 18:40 +0200
  Re: livepatch: Avoid possible race when releasing the patch Jessica Yu <jeyu@redhat.com> - 2016-05-23 23:40 +0200
    Re: livepatch: Avoid possible race when releasing the patch Miroslav Benes <mbenes@suse.cz> - 2016-05-25 11:00 +0200
      Re: livepatch: Avoid possible race when releasing the patch Petr Mladek <pmladek@suse.com> - 2016-05-30 17:40 +0200

csiph-web