Re: [PATCH v5 4/5] mmc: debugfs: add HS400 enhanced strobe description

From	Doug Anderson <dianders@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 4/5] mmc: debugfs: add HS400 enhanced strobe description
Date	2016-05-23 23:00 +0200
Message-ID	<rC57c-2h8-27@gated-at.bofh.it> (permalink)
References	<rBPvr-19U-3@gated-at.bofh.it> <rBPvr-19U-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Shawn,

On Sun, May 22, 2016 at 9:14 PM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> We introduce HS400 with enhanced strobe function, so we need
> to add it for debug show.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>  drivers/mmc/core/debugfs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
> index 9382a57..51d7c38 100644
> --- a/drivers/mmc/core/debugfs.c
> +++ b/drivers/mmc/core/debugfs.c
> @@ -148,7 +148,9 @@ static int mmc_ios_show(struct seq_file *s, void *data)
>                 str = "mmc HS200";
>                 break;
>         case MMC_TIMING_MMC_HS400:
> -               str = "mmc HS400";
> +               mmc_card_hs400es(host->card) ?
> +                       (str = "mmc HS400 enhanced strobe") :
> +                       (str = "mmc HS400");

Not sure it's terribly important, but I've typically seen this as:

str = mmc_card_hs400es(host->card) ?
          "mmc HS400 enhanced strobe" : "mmc HS400";

AKA: don't repeat the "str ="

I doubt it really matters that much, though, so:

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>

Thread

[PATCH v5 4/5] mmc: debugfs: add HS400 enhanced strobe description Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-23 06:20 +0200
  Re: [PATCH v5 4/5] mmc: debugfs: add HS400 enhanced strobe description Doug Anderson <dianders@chromium.org> - 2016-05-23 23:00 +0200
    Re: [PATCH v5 4/5] mmc: debugfs: add HS400 enhanced strobe  description Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-24 04:00 +0200
  Re: [PATCH v5 4/5] mmc: debugfs: add HS400 enhanced strobe description Jaehoon Chung <jh80.chung@samsung.com> - 2016-05-24 12:30 +0200

csiph-web