Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1405517

Re: [PATCH 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events

From Andy Lutomirski <luto@amacapital.net>
Newsgroups linux.kernel
Subject Re: [PATCH 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events
Date 2016-05-23 19:10 +0200
Message-ID <rC1wB-d5-1@gated-at.bofh.it> (permalink)
References <rBzTH-dM-3@gated-at.bofh.it> <rBzTH-dM-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, May 22, 2016 at 4:36 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
> This patch unify procedure for generating sparse keymap and unify also big
> switch code for processing WMI events of different types. After this patch
> dell-wmi driver does not differ between "old" and "new" hotkey type.
>
> It construct sparse keymap table with all WMI codes. It is because on some
> laptops (e.g. Dell Latitude E6440) ACPI/firmware send both event types (old
> and new).
>
> Each WMI code in sparse keymap table is prefixed by 16bit event type, so it
> does not change functionality on laptops with "old" hotkey support (those
> without scancodes in DMI).

This seems like a nice cleanup.  I'll try to test it soon.

--Andy

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events Pali Rohár <pali.rohar@gmail.com> - 2016-05-22 13:40 +0200
  Re: [PATCH 4/4] dell-wmi: Rework code for generating sparse keymap  and processing WMI events Andy Lutomirski <luto@amacapital.net> - 2016-05-23 19:10 +0200

csiph-web