Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1404883

[PATCH 0/2] f_fs: better handle excess data on read

Show all headers | View raw

Between this set and Du, Changbin’s patch, we now have implementation
for the following three possibilities to choose from:
1. Buffer excess data (this whole patch set).
2. Fail the transfer (Du, Changbin’s patch).
3. Drop excess data (the first patch from this set).

As per earlier comments, I think 3. is the correct, i.e. the second
patch should not be ocmmited because:
* it complicates the code,
* doesn’t handle AIO anyway,
* introduces weird behaviours when partial read happens just before
  endpoint is disabled (we may end up silently dropping excess data
  anyway),
* goes beyond what UDC does and
* breaks one read -> one request model which has been true so far.

Michal Nazarewicz (2):
  usb: gadget: f_fs: printk error when excess data is dropped on read
  usb: gadget: f_fs: buffer data from ‘oversized’ OUT requests

 drivers/usb/gadget/function/f_fs.c | 179 ++++++++++++++++++++++++++++++-------
 1 file changed, 145 insertions(+), 34 deletions(-)

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] f_fs: better handle excess data on read Michal Nazarewicz <mina86@mina86.com> - 2016-05-21 20:50 +0200
  [PATCH 1/2] usb: gadget: f_fs: printk error when excess data is dropped on read Michal Nazarewicz <mina86@mina86.com> - 2016-05-21 20:50 +0200
  [PATCH 2/2] usb: gadget: f_fs: buffer data from ‘oversized’ OUT requests Michal Nazarewicz <mina86@mina86.com> - 2016-05-21 20:50 +0200

csiph-web