Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1404854

Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver

From Rob Landley <rob@landley.net>
Newsgroups linux.kernel
Subject Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver
Date 2016-05-21 18:00 +0200
Message-ID <rBhtM-5pd-9@gated-at.bofh.it> (permalink)
References <rAIPn-8gr-3@gated-at.bofh.it> <rAIPo-8gr-21@gated-at.bofh.it> <rAThL-6uH-13@gated-at.bofh.it> <rB5Ch-6Eh-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 05/20/2016 10:15 PM, Rich Felker wrote:
> On Fri, May 20, 2016 at 04:01:56PM +0200, Daniel Lezcano wrote:
>>> +	return ((u64)sechi << 32 | seclo) * 1000000000 + nsec;
>>
>> s/1000000000/NSEC_PER_SEC/
...
>>> +	hwirq = irq_get_irq_data(pit_irq)->hwirq;
>>> +	enable_val = (1<<26) | ((hwirq&0x3c)<<18) | (hwirq<<12);
>>
>> Can you explain? (and replace litterals by macros).

  "Hiding numbers that are used just once into defines to put them
   out of sight does not really help readability." - Pavel Machek

  http://lkml.iu.edu/hypermail/linux/kernel/1407.1/00299.html

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/12] J-core J2 cpu and SoC peripherals support Rich Felker <dalias@libc.org> - 2016-05-20 05:00 +0200
  [PATCH v2 04/12] of: add J-Core timer bindings Rich Felker <dalias@libc.org> - 2016-05-20 05:00 +0200
    Re: [PATCH v2 04/12] of: add J-Core timer bindings Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-20 10:10 +0200
  [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver Rich Felker <dalias@libc.org> - 2016-05-20 05:00 +0200
    Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-05-20 16:10 +0200
      Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver Rich Felker <dalias@libc.org> - 2016-05-21 05:20 +0200
        Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver Rob Landley <rob@landley.net> - 2016-05-21 18:00 +0200
        Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-05-23 22:40 +0200
          Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver Rich Felker <dalias@libc.org> - 2016-05-24 04:30 +0200
  [PATCH v2 01/12] of: add vendor prefix for J-Core Rich Felker <dalias@libc.org> - 2016-05-20 05:00 +0200
    Re: [PATCH v2 01/12] of: add vendor prefix for J-Core Rob Herring <robh@kernel.org> - 2016-05-23 22:50 +0200
  [PATCH v2 05/12] of: add J-Core SPI master bindings Rich Felker <dalias@libc.org> - 2016-05-20 05:00 +0200
    Re: [PATCH v2 05/12] of: add J-Core SPI master bindings Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-20 10:10 +0200
    Re: [PATCH v2 05/12] of: add J-Core SPI master bindings Rich Felker <dalias@libc.org> - 2016-05-23 23:10 +0200
      Re: [PATCH v2 05/12] of: add J-Core SPI master bindings Rob Herring <robh@kernel.org> - 2016-05-24 01:20 +0200
    Re: [PATCH v2 05/12] of: add J-Core SPI master bindings Rob Herring <robh@kernel.org> - 2016-05-23 23:10 +0200
  [PATCH v2 11/12] sh: add defconfig for J-Core J2 Rich Felker <dalias@libc.org> - 2016-05-20 05:00 +0200
  [PATCH v2 03/12] of: add J-Core interrupt controller bindings Rich Felker <dalias@libc.org> - 2016-05-20 05:00 +0200
    Re: [PATCH v2 03/12] of: add J-Core interrupt controller bindings Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-20 10:10 +0200
      Re: [PATCH v2 03/12] of: add J-Core interrupt controller bindings Rich Felker <dalias@libc.org> - 2016-05-21 00:40 +0200
        Re: [PATCH v2 03/12] of: add J-Core interrupt controller bindings Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-21 20:10 +0200
          Re: [PATCH v2 03/12] of: add J-Core interrupt controller bindings Rich Felker <dalias@libc.org> - 2016-05-21 21:20 +0200
    Re: [PATCH v2 03/12] of: add J-Core interrupt controller bindings Rob Herring <robh@kernel.org> - 2016-05-23 23:00 +0200
      Re: [PATCH v2 03/12] of: add J-Core interrupt controller bindings Rich Felker <dalias@libc.org> - 2016-05-23 23:20 +0200
        Re: [PATCH v2 03/12] of: add J-Core interrupt controller bindings Marc Zyngier <marc.zyngier@arm.com> - 2016-05-24 10:10 +0200
          Re: [PATCH v2 03/12] of: add J-Core interrupt controller bindings Rich Felker <dalias@libc.org> - 2016-05-25 04:30 +0200

csiph-web