Re: [PATCH] blk: remove NULL check before freeing functions

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Jeff Moyer <jmoyer@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] blk: remove NULL check before freeing functions
Date	Mon, 23 May 2016 17:30:01 +0200
Message-ID	<rBZXP-7DR-3@gated-at.bofh.it> (permalink)
References	<rBSjF-2RI-55@gated-at.bofh.it>
X-Original-To	Mike Danese <mikedanese@google.com>
User-Agent	Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
X-PGP-Keyid	1F78E1B4
X-PGP-Certkey	F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4
X-Pcloadletter	What the f**k does that mean?
MIME-Version	1.0
Content-Type	text/plain
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.26
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 23 May 2016 15:20:21 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	83
Organization	linux.* mail to news gateway
X-Original-Cc	kernel-janitors@vger.kernel.org, Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org (open list:BLOCK LAYER), linux-kernel@vger.kernel.org (open list)
X-Original-Date	Mon, 23 May 2016 11:20:19 -0400
X-Original-Message-ID	<x4937p86bt8.fsf@segfault.boston.devel.redhat.com>
X-Original-References	<1463987633-125741-1-git-send-email-mikedanese@google.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1405446

Show key headers only | View raw

Mike Danese <mikedanese@google.com> writes:

> Coccinelle complains:
>
> WARNING: NULL check before freeing functions like kfree, debugfs_remove,
> debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider
> reorganizing relevant code to avoid passing NULL values.
>
> Signed-off-by: Mike Danese <mikedanese@google.com>

Acked-by: Jeff Moyer <jmoyer@redhat.com>

> ---
>  block/bio-integrity.c | 7 ++-----
>  block/bio.c           | 7 ++-----
>  block/blk-core.c      | 3 +--
>  block/elevator.c      | 3 +--
>  4 files changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/block/bio-integrity.c b/block/bio-integrity.c
> index 711e4d8d..27bf4e7 100644
> --- a/block/bio-integrity.c
> +++ b/block/bio-integrity.c
> @@ -499,11 +499,8 @@ EXPORT_SYMBOL(bioset_integrity_create);
>  
>  void bioset_integrity_free(struct bio_set *bs)
>  {
> -	if (bs->bio_integrity_pool)
> -		mempool_destroy(bs->bio_integrity_pool);
> -
> -	if (bs->bvec_integrity_pool)
> -		mempool_destroy(bs->bvec_integrity_pool);
> +	mempool_destroy(bs->bio_integrity_pool);
> +	mempool_destroy(bs->bvec_integrity_pool);
>  }
>  EXPORT_SYMBOL(bioset_integrity_free);
>  
> diff --git a/block/bio.c b/block/bio.c
> index 0e4aa42..e1e1773 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -1844,11 +1844,8 @@ void bioset_free(struct bio_set *bs)
>  	if (bs->rescue_workqueue)
>  		destroy_workqueue(bs->rescue_workqueue);
>  
> -	if (bs->bio_pool)
> -		mempool_destroy(bs->bio_pool);
> -
> -	if (bs->bvec_pool)
> -		mempool_destroy(bs->bvec_pool);
> +	mempool_destroy(bs->bio_pool);
> +	mempool_destroy(bs->bvec_pool);
>  
>  	bioset_integrity_free(bs);
>  	bio_put_slab(bs);
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 2475b1c7..916e7c3 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -636,8 +636,7 @@ int blk_init_rl(struct request_list *rl, struct request_queue *q,
>  
>  void blk_exit_rl(struct request_list *rl)
>  {
> -	if (rl->rq_pool)
> -		mempool_destroy(rl->rq_pool);
> +	mempool_destroy(rl->rq_pool);
>  }
>  
>  struct request_queue *blk_alloc_queue(gfp_t gfp_mask)
> diff --git a/block/elevator.c b/block/elevator.c
> index c3555c9..5dc91ca 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -847,8 +847,7 @@ int elv_register(struct elevator_type *e)
>  	spin_lock(&elv_list_lock);
>  	if (elevator_find(e->elevator_name)) {
>  		spin_unlock(&elv_list_lock);
> -		if (e->icq_cache)
> -			kmem_cache_destroy(e->icq_cache);
> +		kmem_cache_destroy(e->icq_cache);
>  		return -EBUSY;
>  	}
>  	list_add_tail(&e->list, &elv_list);

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] blk: remove NULL check before freeing functions Mike Danese <mikedanese@google.com> - 2016-05-23 09:20 +0200
  Re: [PATCH] blk: remove NULL check before freeing functions Jeff Moyer <jmoyer@redhat.com> - 2016-05-23 17:30 +0200

csiph-web